Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755730AbbFLPBk (ORCPT ); Fri, 12 Jun 2015 11:01:40 -0400 Received: from na3sys010aog111.obsmtp.com ([74.125.245.90]:58506 "EHLO mail-la0-f50.google.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1755709AbbFLPBj (ORCPT ); Fri, 12 Jun 2015 11:01:39 -0400 MIME-Version: 1.0 In-Reply-To: <1903121.bsBlXHXLzb@vostro.rjw.lan> References: <25627634.TOSvDFmF1a@vostro.rjw.lan> <1903121.bsBlXHXLzb@vostro.rjw.lan> From: Roland Dreier Date: Fri, 12 Jun 2015 08:01:15 -0700 Message-ID: Subject: Re: Regression in 3.10.80 vs. 3.10.79 To: "Rafael J. Wysocki" Cc: LKML , "Rafael J. Wysocki" , George McCollister , ACPI Devel Maling List , Bjorn Helgaas Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2107 Lines: 55 On Thu, Jun 11, 2015 at 1:50 PM, Rafael J. Wysocki wrote: > Changing the ordering between those two routines would work around that problem, > but in my view that wouldn't be a proper fix. In fact, the role of reserve_range() > is to reserve the resources so as to prevent them from being used going forward, > so they need not be reserved each in one piece. Instead, we can just check if they > overlap with the ones reserved by acpi_reserve_resources() and only request the > non-overlapping parts of them to avoid conflicts. > > So I wonder if the patch below makes any difference? I will give this a try and make sure it fixes my system, although I'm pretty sure it will. However I'm not sure I agree that this is a better fix than just having pnp reserve ranges before acpi. It already creates a special relationship between pnp and acpi, and acpi_reserve_region is a bunch of extra code. Could we really have a system where the hierarchy of acpi being a subset of a pnp bus doesn't work? I looked at a few other systems I have, and things like the following seem quite common: supermicro: 03e0-0cf7 : PCI Bus 0000:00 03f8-03ff : serial 0400-0453 : pnp 00:0c 0400-0403 : ACPI PM1a_EVT_BLK 0404-0405 : ACPI PM1a_CNT_BLK 0408-040b : ACPI PM_TMR 0410-0415 : ACPI CPU throttle 0420-042f : ACPI GPE0_BLK 0430-0433 : iTCO_wdt 0450-0450 : ACPI PM2_CNT_BLK dell: 03e0-0cf7 : PCI Bus 0000:00 03f8-03ff : serial 0800-087f : pnp 00:06 0800-0803 : ACPI PM1a_EVT_BLK 0804-0805 : ACPI PM1a_CNT_BLK 0808-080b : ACPI PM_TMR 0810-0815 : ACPI CPU throttle 0820-082f : ACPI GPE0_BLK 0830-0833 : iTCO_wdt 0830-0833 : iTCO_wdt 0850-0850 : ACPI PM2_CNT_BLK 0860-087f : iTCO_wdt 0860-087f : iTCO_wdt but I wasn't able to find anything that required more generality... -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/