Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755410AbbFLPGv (ORCPT ); Fri, 12 Jun 2015 11:06:51 -0400 Received: from e39.co.us.ibm.com ([32.97.110.160]:51481 "EHLO e39.co.us.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753458AbbFLPGu (ORCPT ); Fri, 12 Jun 2015 11:06:50 -0400 X-Helo: d01dlp01.pok.ibm.com X-MailFrom: nacc@linux.vnet.ibm.com X-RcptTo: linux-kernel@vger.kernel.org Date: Fri, 12 Jun 2015 08:06:43 -0700 From: Nishanth Aravamudan To: Gavin Shan Cc: Alexey Kardashevskiy , linux-kernel@vger.kernel.org, Paul Mackerras , linuxppc-dev@lists.ozlabs.org, David Gibson Subject: Re: [PATCH kernel] powerpc/powernv/ioda2: Add devices only from buses which belong to PE Message-ID: <20150612150643.GA55122@linux.vnet.ibm.com> References: <1434089957-27135-1-git-send-email-aik@ozlabs.ru> <20150612064703.GA17776@gwshan> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150612064703.GA17776@gwshan> X-Operating-System: Linux 3.13.0-40-generic (x86_64) User-Agent: Mutt/1.5.21 (2010-09-15) X-TM-AS-MML: disable X-Content-Scanned: Fidelis XPS MAILER x-cbid: 15061215-0033-0000-0000-000004D387B8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1312 Lines: 31 On 12.06.2015 [16:47:03 +1000], Gavin Shan wrote: > On Fri, Jun 12, 2015 at 04:19:17PM +1000, Alexey Kardashevskiy wrote: > >The existing code puts all devices from a root PE to the same IOMMU group. > >However it is a possible situation when subordinate buses belong to > >separate PEs, in this case devices from these subordinate buses > >should be added to lower level PE rather to the root PE. > > > >This limits pnv_ioda_setup_bus_dma() invocation to only PEs which own > >all subordinate buses. > > > >Suggested-by: Gavin Shan > >Signed-off-by: Alexey Kardashevskiy > > Alexey, I think it's good candidate for stable. Why? This commit message doesn't imply there is a serious bug just a "possible" (does that mean theoretical?) situtation and the following: > >This would be nice to have together with the DDW patchset. > >This does not fix anything DDW patchset did, it fixes IOMMU > >groups management which is essential for the whole feature to work. implies it is both related and independent of DDW? -Nish -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/