Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754013AbbFLPgy (ORCPT ); Fri, 12 Jun 2015 11:36:54 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:55958 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751130AbbFLPgu (ORCPT ); Fri, 12 Jun 2015 11:36:50 -0400 Date: Fri, 12 Jun 2015 08:36:49 -0700 From: "gregkh@linuxfoundation.org" To: "Abdul, Hussain (H.)" Cc: "vthakkar1994@gmail.com" , "hamohammed.sa@gmail.com" , "devel@driverdev.osuosl.org" , "linux-kernel@vger.kernel.org" , "tapaswenipathak@gmail.com" Subject: Re: [PATCH] staging: ste_rmi4: Add IRQF_ONESHOT flag Message-ID: <20150612153649.GB30967@kroah.com> References: <1434017608-20304-1-git-send-email-habdul@visteon.com> <20150611143640.GA24637@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23+89 (0255b37be491) (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1671 Lines: 38 On Fri, Jun 12, 2015 at 06:47:25AM +0000, Abdul, Hussain (H.) wrote: > On Thursday 11 June 2015 08:06 PM, gregkh@linuxfoundation.org wrote: > > On Thu, Jun 11, 2015 at 10:14:49AM +0000, Abdul, Hussain (H.) wrote: > >> This patch add IRQF_ONESHOT flag in threaded IRQs request without a primary handler. > >> > >> Signed-off-by: Abdul Hussain > >> --- > >> drivers/staging/ste_rmi4/synaptics_i2c_rmi4.c | 2 +- > >> 1 file changed, 1 insertion(+), 1 deletion(-) > >> > >> diff --git a/drivers/staging/ste_rmi4/synaptics_i2c_rmi4.c b/drivers/staging/ste_rmi4/synaptics_i2c_rmi4.c > >> index 0f524bb..7caaae0 100644 > >> --- a/drivers/staging/ste_rmi4/synaptics_i2c_rmi4.c > >> +++ b/drivers/staging/ste_rmi4/synaptics_i2c_rmi4.c > >> @@ -987,7 +987,7 @@ static int synaptics_rmi4_probe > >> rmi4_data->number_of_interrupt_register); > >> retval = request_threaded_irq(client->irq, NULL, > >> synaptics_rmi4_irq, > >> - platformdata->irq_type, > >> + platformdata->irq_type | IRQF_ONESHOT, > >> DRIVER_NAME, rmi4_data); > >> if (retval) { > >> dev_err(&client->dev, "Unable to get attn irq %d\n", > > Have you tested this? This changes the behavior of the code, right? > > > Greg, > > I haven't tested this changes. Yes, this will change the behavior of the code. Then I can't accept this, sorry. Why would you make a behavior change without testing something? greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/