Message-ID: <557B0547.4000503@intel.com>
Date: Fri, 12 Jun 2015 19:13:59 +0300
From: Adrian Hunter <adrian.hunter@intel.com>
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0
MIME-Version: 1.0
To: David Ahern <dsahern@gmail.com>
CC: Peter Zijlstra <peterz@infradead.org>, Andi Kleen <ak@linux.intel.com>,
        Arnaldo Carvalho de Melo <acme@kernel.org>,
        Ingo Molnar <mingo@kernel.org>, linux-kernel@vger.kernel.org,
        Jiri Olsa <jolsa@redhat.com>, Stephane Eranian <eranian@google.com>,
        mathieu.poirier@linaro.org, Pawel Moll <pawel.moll@arm.com>
Subject: Re: [RFC PATCH] perf: Add PERF_RECORD_SWITCH to indicate context
 switches
References: <1433859670-10806-1-git-send-email-adrian.hunter@intel.com> <20150611141548.GW19282@twins.programming.kicks-ass.net> <557A2C14.4010804@gmail.com> <557AB5D1.9050905@intel.com> <557AEAF9.5050507@gmail.com>
In-Reply-To: <557AEAF9.5050507@gmail.com>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1600
Lines: 33

On 12/06/2015 5:21 p.m., David Ahern wrote:
> On 6/12/15 4:34 AM, Adrian Hunter wrote:
>> On 12/06/15 03:47, David Ahern wrote:
>>> On 6/11/15 8:15 AM, Peter Zijlstra wrote:
>>>>> This new PERF_RECORD_SWITCH event does not have those problems
>>>>> and it also has a couple of other small advantages. It is
>>>>> easier to use because it is an auxiliary event (like mmap,
>>>>> comm and task events) which can be enabled by setting a single
>>>>> bit. It is smaller than sched:sched_switch and easier to parse.
>>>>
>>>> Right, so the one wee problem I have is that this only provides sched_in
>>>> data, I imagine people might be interested in sched_out as well.
>>>
>>> Yes and with the option of collecting callchains for sched_out.
>>
>> So what do you want that is different different from
>> PERF_COUNT_SW_CONTEXT_SWITCHES? And why?
>>
>
> My 'perf sched timehist' command can use either sched_switch and context
> switches. As you have pointed out you need to collect them system wide even if
> you only care about a subset of tasks. If you are going to add a sched_in
> there is good symmetry by also having a sched_out that is used and generated
> in a consistent manner.

Yes I will certainly add sched out, but the new thing is not a sample so it 
does not have callchains. But presumably you could use 
PERF_COUNT_SW_CONTEXT_SWITCHES as well?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/