Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755614AbbFLQXK (ORCPT ); Fri, 12 Jun 2015 12:23:10 -0400 Received: from mail-wg0-f45.google.com ([74.125.82.45]:34968 "EHLO mail-wg0-f45.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753100AbbFLQXH (ORCPT ); Fri, 12 Jun 2015 12:23:07 -0400 Date: Fri, 12 Jun 2015 18:23:03 +0200 (CEST) From: Hans Ulli Kroll X-X-Sender: elektroman@T520.local To: Rob Herring cc: Hans Ulli Kroll , Russell King , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , "arm@kernel.org" , Sekhar Nori , Kevin Hilman , Jason Cooper , Andrew Lunn , Sebastian Hesselbarth , Gregory Clement , Shawn Guo , Sascha Hauer , Imre Kaloz , Krzysztof Halasa , Greg Ungerer , Roland Stigge , Tony Lindgren , Daniel Mack , Haojian Zhuang , Robert Jarzmik , Simtec Linux Team , Kukjin Kim , Krzysztof Kozlowski , Wan ZongShun , linux-omap , "linux-samsung-soc@vger.kernel.org" Subject: Re: [PATCH 01/15] ARM: kill off set_irq_flags usage In-Reply-To: Message-ID: References: <1433874401-27161-1-git-send-email-robh@kernel.org> <1433874401-27161-2-git-send-email-robh@kernel.org> User-Agent: Alpine 2.00 (LNX 1167 2008-08-23) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1388 Lines: 44 On Fri, 12 Jun 2015, Rob Herring wrote: > On Fri, Jun 12, 2015 at 9:05 AM, Hans Ulli Kroll > wrote: > > > > > > On Tue, 9 Jun 2015, Rob Herring wrote: > > > >> set_irq_flags is ARM specific with custom flags which have genirq > >> equivalents. Convert drivers to use the genirq interfaces directly, so we > >> can kill off set_irq_flags. The translation of flags is as follows: > >> > >> IRQF_VALID -> !IRQ_NOREQUEST > >> IRQF_PROBE -> !IRQ_NOPROBE > >> IRQF_NOAUTOEN -> IRQ_NOAUTOEN > >> > >> For IRQs managed by an irqdomain, the irqdomain core code handles clearing > >> and setting IRQ_NOREQUEST already, so there is no need to do this in > >> .map() functions and we can simply remove the set_irq_flags calls. Some > >> users also set IRQ_NOPROBE and this has been maintained although it is not > >> clear that is really needed. There appears to be a great deal of blind > >> copy and paste of this code. > >> > > > > for mach-gemini > > Signed-off-by: Hans Ulli Kroll > > You mean acked-by, right? > > Rob > Yeah Acked-by: Hans Ulli Kroll Ulli -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/