Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755954AbbFLQd5 (ORCPT ); Fri, 12 Jun 2015 12:33:57 -0400 Received: from smtp02.citrix.com ([66.165.176.63]:51015 "EHLO SMTP02.CITRIX.COM" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755752AbbFLQdx (ORCPT ); Fri, 12 Jun 2015 12:33:53 -0400 X-IronPort-AV: E=Sophos;i="5.13,602,1427760000"; d="scan'208";a="274340443" Message-ID: <557B09EA.6000503@citrix.com> Date: Fri, 12 Jun 2015 17:33:46 +0100 From: David Vrabel User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Icedove/31.4.0 MIME-Version: 1.0 To: Greg KH , Juergen Gross CC: , , , , Subject: Re: [Xen-devel] [Patch V2 2/3] usb: Introduce Xen pvUSB frontend References: <1434118201-25617-1-git-send-email-jgross@suse.com> <1434118201-25617-3-git-send-email-jgross@suse.com> <20150612162007.GC15911@kroah.com> In-Reply-To: <20150612162007.GC15911@kroah.com> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit X-DLP: MIA2 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1755 Lines: 42 On 12/06/15 17:20, Greg KH wrote: > On Fri, Jun 12, 2015 at 04:10:00PM +0200, Juergen Gross wrote: >> Introduces the Xen pvUSB frontend. With pvUSB it is possible for a Xen >> domU to communicate with a USB device assigned to that domU. The >> communication is all done via the pvUSB backend in a driver domain >> (usually Dom0) which is owner of the physical device. >> >> The code is taken from the pvUSB implementation in Xen done by Fujitsu >> based on Linux kernel 2.6.18. >> >> Changes from the original version are: >> - port to upstream kernel >> - put all code in just one source file >> - move module to appropriate location in kernel tree >> - adapt to Linux style guide >> - minor code modifications to increase readability >> >> Signed-off-by: Juergen Gross >> --- >> drivers/usb/Kconfig | 2 + >> drivers/usb/Makefile | 2 + >> drivers/usb/xen/Kconfig | 10 + >> drivers/usb/xen/Makefile | 5 + >> drivers/usb/xen/xen-usbfront.c | 1647 ++++++++++++++++++++++++++++++++++++++++ > > A subdirectory for a single file? That seems like overkill, don't you > think? As this is a USB "host" driver, why not put it in that > directory? > > Also, last time these patches were posted, people asked why you can't > use libusb/usbfs instead, what happened with that? Or usbip? Using libusb was for the backend driver. This frontend driver is a host controller (which is why it should be drivers/usb/host/xen-pv-hcd.c or similar). David -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/