Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753666AbbFLQ6f (ORCPT ); Fri, 12 Jun 2015 12:58:35 -0400 Received: from hofr.at ([212.69.189.236]:34237 "EHLO mail.hofr.at" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751199AbbFLQ6c (ORCPT ); Fri, 12 Jun 2015 12:58:32 -0400 Date: Fri, 12 Jun 2015 18:58:29 +0200 From: Nicholas Mc Guire To: Stanislav Yakovlev Cc: Kalle Valo , James Ketrenos , linux-wireless@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [BUG ?] delay always evaluates to 0 Message-ID: <20150612165829.GA22474@opentech.at> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.5.18 (2008-05-17) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 826 Lines: 26 Hi ! commit 2c86c275015c ("Add ipw2100 wireless driver.") introduced drivers/net/wireless/ipw2100.c - line-numbers are from next-20150511 1410 static int ipw2100_hw_phy_off(struct ipw2100_priv *priv) 1411 { 1412 1413 #define HW_PHY_OFF_LOOP_DELAY (HZ / 5000) 1414 ... 1437 1438 schedule_timeout_uninterruptible(HW_PHY_OFF_LOOP_DELAY); 1439 } but (HZ / 5000) will evaluate to 0 for all configurable HZ values - typo ? and this schedule_timeout_uninterruptible() is probably not doing what is intended. thx! hofrat -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/