Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753017AbbFLTpG (ORCPT ); Fri, 12 Jun 2015 15:45:06 -0400 Received: from Chamillionaire.breakpoint.cc ([80.244.247.6]:53686 "EHLO Chamillionaire.breakpoint.cc" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750783AbbFLTpB (ORCPT ); Fri, 12 Jun 2015 15:45:01 -0400 Date: Fri, 12 Jun 2015 21:44:39 +0200 From: Sebastian Andrzej Siewior To: Stefan Agner Cc: Sebastian Andrzej Siewior , dwmw2@infradead.org, computersforpeace@gmail.com, mark.rutland@arm.com, boris.brezillon@free-electrons.com, aaron@tastycactus.com, marb@ixxat.de, pawel.moll@arm.com, ijc+devicetree@hellion.org.uk, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, robh+dt@kernel.org, linux-mtd@lists.infradead.org, kernel@pengutronix.de, galak@codeaurora.org, shawn.guo@linaro.org, linux-arm-kernel@lists.infradead.org, bpringlemeir@nbsps.com Subject: Re: [PATCH v4 1/6] mtd: nand: vf610_nfc: Freescale NFC for VF610, MPC5125 and others Message-ID: <20150612194439.GA15327@breakpoint.cc> References: <1427300909-20825-1-git-send-email-stefan@agner.ch> <1427300909-20825-2-git-send-email-stefan@agner.ch> <20150603130825.GA23991@breakpoint.cc> <20150609200751.GC5720@breakpoint.cc> <16ebb290641f700f2262527f90ff1e46@agner.ch> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <16ebb290641f700f2262527f90ff1e46@agner.ch> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1060 Lines: 31 On 2015-06-09 22:31:07 [+0200], Stefan Agner wrote: > > have the endian swap. So an abstraction like you provided earlier > > would be nice :) > > What do you mean by that? Something like you did for the reader where you have: |static inline u32 vf610_nfc_read(struct vf610_nfc *nfc, uint reg) |{ | return readl(nfc->regs + reg); |} instead using readl() directly. So you could also have |static inline u32 vf610_nfc_read_relaxed(struct vf610_nfc *nfc, uint reg) |{ | return readl_relaxed(nfc->regs + reg); |} Instead of using readl_relaxed(). Unless I'm mistaken, that function was used more than once. If someone plugs in PPC support he does not need to add this function anymore but but simply add an ifdef in vf610_nfc_read() and vf610_nfc_read_relaxed() and replace it whatever works for him. Sebastian -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/