Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753297AbbFLUaC (ORCPT ); Fri, 12 Jun 2015 16:30:02 -0400 Received: from mail2-relais-roc.national.inria.fr ([192.134.164.83]:58831 "EHLO mail2-relais-roc.national.inria.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751896AbbFLU35 (ORCPT ); Fri, 12 Jun 2015 16:29:57 -0400 X-IronPort-AV: E=Sophos;i="5.13,604,1427752800"; d="scan'208";a="164924298" Date: Fri, 12 Jun 2015 22:29:53 +0200 (CEST) From: Julia Lawall X-X-Sender: jll@localhost6.localdomain6 To: Thomas Gleixner cc: Julia Lawall , Jiang Liu , Bjorn Helgaas , Benjamin Herrenschmidt , Ingo Molnar , "H. Peter Anvin" , "Rafael J. Wysocki" , Randy Dunlap , Yinghai Lu , Borislav Petkov , Jason Cooper , Kevin Cernekee , Arnd Bergmann , Marc Zyngier , Konrad Rzeszutek Wilk , Tony Luck , x86@kernel.org, LKML , linux-pci@vger.kernel.org, linux-acpi@vger.kernel.org Subject: Re: [RFC v1 14/25] genirq: Kill the first parameter 'irq' of irq_flow_handler_t In-Reply-To: Message-ID: References: <1432116013-25902-1-git-send-email-jiang.liu@linux.intel.com> <1432116013-25902-15-git-send-email-jiang.liu@linux.intel.com> <555CA834.7080807@linux.intel.com> User-Agent: Alpine 2.02 (DEB 1266 2009-07-14) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1667 Lines: 39 On Wed, 20 May 2015, Thomas Gleixner wrote: > On Wed, 20 May 2015, Julia Lawall wrote: > > On Wed, 20 May 2015, Thomas Gleixner wrote: > > > On Wed, 20 May 2015, Julia Lawall wrote: > > > > Scripting this may be a little complex, because the variable can be used > > > > in one way in one execution path (eg if branch) and another way (or not at > > > > all) in another. Let me know if help is needed. > > > > > > I feared that, but at least identifying all functions, where the irq > > > argument is used inside the function itself is really key for such a > > > massive rework. > > > > It's not impossible, but I may need to think a bit how best to do it. > > I pretty much expected that you would say that :) > > But seriously, the first important thing is to find all functions and > to check whether they use irq internaly. Jiang has done that > 'manually' or such, so the number of function which need an actual > change are not that big. > > But I certainly don't want to hold you off thinking about it. Such > stuff is not a unique problem :) What is the status of this? I am close to having a semantic patch that works. The current version touches 133 files, but I haven't checked all of them. This includes both the local functions and the generic ones, but not the cases where the name of the handler function is a local variable or arbitrary expression. This occurs in around 30 files. julia -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/