Date: Fri, 12 Jun 2015 16:52:03 -0400
From: Steven Rostedt <rostedt@goodmis.org>
To: Tom Zanussi <tom.zanussi@linux.intel.com>
Cc: daniel.wagner@bmw-carit.de, masami.hiramatsu.pt@hitachi.com,
        namhyung@kernel.org, josh@joshtriplett.org, andi@firstfloor.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH v7 06/10] trace: Add lock-free tracing_map
Message-ID: <20150612165203.51ad8d2b@gandalf.local.home>
In-Reply-To: <e025909c160df379949ea3fb80c76d43a8116587.1433797842.git.tom.zanussi@linux.intel.com>
References: <cover.1433797842.git.tom.zanussi@linux.intel.com>
	<e025909c160df379949ea3fb80c76d43a8116587.1433797842.git.tom.zanussi@linux.intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1286
Lines: 31

On Mon,  8 Jun 2015 16:32:05 -0500
Tom Zanussi <tom.zanussi@linux.intel.com> wrote:

> +/**
> + * tracing_map_init - Allocate and clear a map's tracing_map_elts
> + * @map: The tracing_map to initialize
> + *
> + * Creates and sets up a map to contain a max_size number of entries
> + * equal to a size of 2 ** map_bits.  Before using, the map fields
> + * should be added to the map with tracing_map_add_key_field() and
> + * tracing_map_add_key_field().  tracing_map_init() should then be

Hmm, it's suppose to be added with tracing_map_add_key_field() twice?

-- Steve

> + * called to allocate the array of tracing_map_elts, in order to avoid
> + * allocating anything in the map insertion path.  The user-specified
> + * map_size reflect the max number of entries requested by the user -
> + * internally we double that in order to keep the table sparse and
> + * keep collisions manageable.
> + *
> + * See tracing_map.h for a description of tracing_map_ops.
> + *
> + * Return: the tracing_map * if successful, ERR_PTR if not.
> + */
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/