Date: Fri, 12 Jun 2015 23:36:05 +0200
From: Jiri Olsa <jolsa@redhat.com>
To: Wang Nan <wangnan0@huawei.com>
Cc: hekuang@huawei.com, jolsa@kernel.org, acme@redhat.com,
        a.p.zijlstra@chello.nl, lizefan@huawei.com,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH tip/perf/core] tools lib traceevent: Fix python/perf.so
 compiling error
Message-ID: <20150612213605.GD30061@krava.redhat.com>
References: <1434079031-123162-1-git-send-email-wangnan0@huawei.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1434079031-123162-1-git-send-email-wangnan0@huawei.com>
User-Agent: Mutt/1.5.23 (2014-03-12)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1547
Lines: 37

On Fri, Jun 12, 2015 at 03:17:11AM +0000, Wang Nan wrote:
> 'make build-test' finds an error that make_python_perf_so fails due to
> missing of libtraceevent-dynamic-list:
> 
>  '.../python2' util/setup.py \
>    --quiet build_ext; \
>    mkdir -p python && \
>    cp python_ext_build/lib/perf.so python/
>    /path/to/ld: cannot open linker script file /path/to/kernel/tools/lib/traceevent/libtraceevent-dynamic-list: No such file or directory
>    collect2: error: ld returned 1 exit status
>    error: command 'x86_64-linux-gcc' failed with exit status 1
>    cp: cannot stat 'python_ext_build/lib/perf.so': No such file or directory
>    make[3]: *** [python/perf.so] Error 1
>    make[2]: *** [python/perf.so] Error 2
>      test: test -f ./python/perf.so
>      make[1]: *** [make_python_perf_so] Error 1
>      make: *** [build-test] Error 2
>      make: Leaving directory `/path/to/kernel/tools/perf'
> 
> This is caused by commit e3d09ec8126fe2c9a3ade661e2126e215ca27a80
> ("tools lib traceevent: Export dynamic symbols used by traceevent
> plugins") that, it adds the list file to LDFLAGS but forgot to add it
> to dependency list of python/perf.so.
> 
> This patch fixes this problem.
> 
> Signed-off-by: Wang Nan <wangnan0@huawei.com>

Acked-by: Jiri Olsa <jolsa@kernel.org>

thanks,
jirka
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/