Date: Sat, 13 Jun 2015 00:28:30 +0200
From: Oleg Nesterov <oleg@redhat.com>
To: Ingo Molnar <mingo@kernel.org>
Cc: linux-kernel@vger.kernel.org, linux-mml@vger.kernel.org,
        Andy Lutomirski <luto@amacapital.net>,
        Andrew Morton <akpm@linux-foundation.org>,
        Denys Vlasenko <dvlasenk@redhat.com>, Brian Gerst <brgerst@gmail.com>,
        Peter Zijlstra <peterz@infradead.org>, Borislav Petkov <bp@alien8.de>,
        "H. Peter Anvin" <hpa@zytor.com>,
        Linus Torvalds <torvalds@linux-foundation.org>,
        Thomas Gleixner <tglx@linutronix.de>, Waiman Long <Waiman.Long@hp.com>
Subject: Re: [PATCH 04/12] x86/mm/hotplug: Simplify sync_global_pgds()
Message-ID: <20150612222830.GA23855@redhat.com>
References: <1434031637-9091-1-git-send-email-mingo@kernel.org> <1434031637-9091-5-git-send-email-mingo@kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1434031637-9091-5-git-send-email-mingo@kernel.org>
User-Agent: Mutt/1.5.18 (2008-05-17)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 629
Lines: 20

Yes I guess I am totally confused ;)

On 06/11, Ingo Molnar wrote:
>
> @@ -178,7 +178,7 @@ void sync_global_pgds(unsigned long start, unsigned long end, int removed)
>  		 *
>  		 * So clear the affected entries in every process PGD as well:
>  		 */
> -		if (pgd_none(*pgd_ref) && !removed)
> +		if (pgd_none(*pgd_ref))

But doesn't this change invalidate the comment above?

Oleg.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/