Message-ID: <557B960B.60504@plumgrid.com>
Date: Fri, 12 Jun 2015 19:31:39 -0700
From: Alexei Starovoitov <ast@plumgrid.com>
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.10; rv:31.0) Gecko/20100101 Thunderbird/31.7.0
MIME-Version: 1.0
To: Wang Nan <wangnan0@huawei.com>, acme@kernel.org, brendan.d.gregg@gmail.com,
        daniel@iogearbox.net, namhyung@kernel.org,
        masami.hiramatsu.pt@hitachi.com, paulus@samba.org,
        a.p.zijlstra@chello.nl, mingo@redhat.com, jolsa@kernel.org,
        dsahern@gmail.com
CC: linux-kernel@vger.kernel.org, lizefan@huawei.com, hekuang@huawei.com,
        xiakaixu@huawei.com, pi3orama@163.com
Subject: Re: [RFC PATCH v7 23/37] perf tools: Introduce llvm config options
References: <1434087345-127225-1-git-send-email-wangnan0@huawei.com> <1434087345-127225-24-git-send-email-wangnan0@huawei.com>
In-Reply-To: <1434087345-127225-24-git-send-email-wangnan0@huawei.com>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 698
Lines: 18

On 6/11/15 10:35 PM, Wang Nan wrote:
>          # Path to clang. If omit, search it from $PATH.
> 	clang-path = "/path/to/clang"

I think this bit and search_program() from the next patch is
overly flexible. It's always delicate to search file paths.
Unless this is really needed, I would drop this bit.
popen() in the next patch executes clang via shell,
so explicit PATH search in unnecessary.

The rest of the patches look good to me.
Thanks again.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/