Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753754AbbFMCyO (ORCPT ); Fri, 12 Jun 2015 22:54:14 -0400 Received: from m12-15.163.com ([220.181.12.15]:58938 "EHLO m12-15.163.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751362AbbFMCyM convert rfc822-to-8bit (ORCPT ); Fri, 12 Jun 2015 22:54:12 -0400 Content-Type: text/plain; charset=gb2312 Mime-Version: 1.0 (1.0) Subject: Re: [RFC PATCH v7 23/37] perf tools: Introduce llvm config options From: pi3orama X-Mailer: iPhone Mail (12F70) In-Reply-To: <557B960B.60504@plumgrid.com> Date: Sat, 13 Jun 2015 10:52:24 +0800 Cc: Wang Nan , "acme@kernel.org" , "brendan.d.gregg@gmail.com" , "daniel@iogearbox.net" , "namhyung@kernel.org" , "masami.hiramatsu.pt@hitachi.com" , "paulus@samba.org" , "a.p.zijlstra@chello.nl" , "mingo@redhat.com" , "jolsa@kernel.org" , "dsahern@gmail.com" , "linux-kernel@vger.kernel.org" , "lizefan@huawei.com" , "hekuang@huawei.com" , "xiakaixu@huawei.com" Content-Transfer-Encoding: 8BIT Message-Id: <195F4F7A-2206-40D5-BD45-BACD61E81C8F@163.com> References: <1434087345-127225-1-git-send-email-wangnan0@huawei.com> <1434087345-127225-24-git-send-email-wangnan0@huawei.com> <557B960B.60504@plumgrid.com> To: Alexei Starovoitov X-CM-TRANSID: D8CowEAJ8FznmntVr6+xCA--.18425S2 X-Coremail-Antispam: 1Uf129KBjvdXoW7XF1xGF13uw4Utw4rCFy5twb_yoWDXwb_Kr 10q34kCw42qryDAF1DtrWayrWfGFZFkrWfZrZ5urZ3t3sYy3ykuayvkayfAF48CFn2vF98 Wwn7ZrWqkr47ujkaLaAFLSUrUUUUUb8apTn2vfkv8UJUUUU8Yxn0WfASr-VFAUDa7-sFnT 9fnUUvcSsGvfC2KfnxnUUI43ZEXa7IU87xhJUUUUU== X-Originating-IP: [117.136.38.86] X-CM-SenderInfo: lslt02xdpdqiywtou0bp/xtbBaQoYQFD-+wNnAQAAsK Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1268 Lines: 32 ?????ҵ? iPhone > ?? 2015??6??13?գ?????10:31??Alexei Starovoitov д???? > >> On 6/11/15 10:35 PM, Wang Nan wrote: >> # Path to clang. If omit, search it from $PATH. >> clang-path = "/path/to/clang" > > I think this bit and search_program() from the next patch is > overly flexible. It's always delicate to search file paths. > Unless this is really needed, I would drop this bit. I think searching clang before execution is still equired. If not, we are unable to know the exact reason why the shell script failed. If there's no clang at all, we can simply return an error instead of trying to detect kbuild and kernel header. Which is slower than clang compiling itself. What about creating another shell script simply run 'clang --version' to check availability of clang? Then search_program can be dropped. Thank you. > popen() in the next patch executes clang via shell, > so explicit PATH search in unnecessary. > > The rest of the patches look good to me. > Thanks again. > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/