Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751270AbbFMEaL (ORCPT ); Sat, 13 Jun 2015 00:30:11 -0400 Received: from m12-12.163.com ([220.181.12.12]:60643 "EHLO m12-12.163.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750725AbbFMEaG convert rfc822-to-8bit (ORCPT ); Sat, 13 Jun 2015 00:30:06 -0400 Content-Type: text/plain; charset=gb2312 Mime-Version: 1.0 (1.0) Subject: Re: [RFC PATCH v7 23/37] perf tools: Introduce llvm config options From: pi3orama X-Mailer: iPhone Mail (12F70) In-Reply-To: <557B960B.60504@plumgrid.com> Date: Sat, 13 Jun 2015 12:11:42 +0800 Cc: Wang Nan , "acme@kernel.org" , "brendan.d.gregg@gmail.com" , "daniel@iogearbox.net" , "namhyung@kernel.org" , "masami.hiramatsu.pt@hitachi.com" , "paulus@samba.org" , "a.p.zijlstra@chello.nl" , "mingo@redhat.com" , "jolsa@kernel.org" , "dsahern@gmail.com" , "linux-kernel@vger.kernel.org" , "lizefan@huawei.com" , "hekuang@huawei.com" , "xiakaixu@huawei.com" Content-Transfer-Encoding: 8BIT Message-Id: References: <1434087345-127225-1-git-send-email-wangnan0@huawei.com> <1434087345-127225-24-git-send-email-wangnan0@huawei.com> <557B960B.60504@plumgrid.com> To: Alexei Starovoitov X-CM-TRANSID: DMCowEDJ7VJ9rXtVaxG9CA--.44930S2 X-Coremail-Antispam: 1Uf129KBjvdXoW7XF1xGF13uw4Utw4rCFy5twb_yoWkWrg_Kr 18Jr1kCrn7XFWDXa4Yyr45ArZxGa9rKry3XrZ5ur4kX34Iq3Z0kaykKFyfXF43CF9rZ3Z8 J3WkXFWYkw1fWjkaLaAFLSUrUUUUUb8apTn2vfkv8UJUUUU8Yxn0WfASr-VFAUDa7-sFnT 9fnUUvcSsGvfC2KfnxnUUI43ZEXa7IU8LL05UUUUU== X-Originating-IP: [210.73.4.168] X-CM-SenderInfo: lslt02xdpdqiywtou0bp/1tbisgAYQFUL2oSz1AAAsN Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1376 Lines: 34 ?????ҵ? iPhone > ?? 2015??6??13?գ?????10:31??Alexei Starovoitov д???? > >> On 6/11/15 10:35 PM, Wang Nan wrote: >> # Path to clang. If omit, search it from $PATH. >> clang-path = "/path/to/clang" > > I think this bit and search_program() from the next patch is > overly flexible. It's always delicate to search file paths. About this clang-path: in my environment the name of clang is x86_64-oe-linux-clang, and installed in /usr/bin/llvm-3.7, neither in $PATH nor has its default name. This is the default setting of yocto and open-embedded based systems. Please see do_install part in building script of it: https://github.com/openembedded/meta-oe/blob/master/meta-oe/recipes-core/llvm/llvm.inc Therefore, I think something like this option should not be dropped, or people like me have to do some nasty work to make it useable. Could you please rethink it? Thank you. > Unless this is really needed, I would drop this bit. > popen() in the next patch executes clang via shell, > so explicit PATH search in unnecessary. > > The rest of the patches look good to me. > Thanks again. > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/