Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751341AbbFMEns (ORCPT ); Sat, 13 Jun 2015 00:43:48 -0400 Received: from mail-pd0-f174.google.com ([209.85.192.174]:34796 "EHLO mail-pd0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751181AbbFMEnj (ORCPT ); Sat, 13 Jun 2015 00:43:39 -0400 Message-ID: <557BB4F9.6020008@plumgrid.com> Date: Fri, 12 Jun 2015 21:43:37 -0700 From: Alexei Starovoitov User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.10; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: pi3orama CC: Wang Nan , "acme@kernel.org" , "brendan.d.gregg@gmail.com" , "daniel@iogearbox.net" , "namhyung@kernel.org" , "masami.hiramatsu.pt@hitachi.com" , "paulus@samba.org" , "a.p.zijlstra@chello.nl" , "mingo@redhat.com" , "jolsa@kernel.org" , "dsahern@gmail.com" , "linux-kernel@vger.kernel.org" , "lizefan@huawei.com" , "hekuang@huawei.com" , "xiakaixu@huawei.com" Subject: Re: [RFC PATCH v7 23/37] perf tools: Introduce llvm config options References: <1434087345-127225-1-git-send-email-wangnan0@huawei.com> <1434087345-127225-24-git-send-email-wangnan0@huawei.com> <557B960B.60504@plumgrid.com> In-Reply-To: Content-Type: text/plain; charset=gbk; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1411 Lines: 32 On 6/12/15 9:11 PM, pi3orama wrote: > > > ?????ҵ? iPhone > >> ?? 2015??6??13?գ?????10:31??Alexei Starovoitov д???? >> >>> On 6/11/15 10:35 PM, Wang Nan wrote: >>> # Path to clang. If omit, search it from $PATH. >>> clang-path = "/path/to/clang" >> >> I think this bit and search_program() from the next patch is >> overly flexible. It's always delicate to search file paths. > > About this clang-path: in my environment the name of clang is x86_64-oe-linux-clang, and installed in /usr/bin/llvm-3.7, neither in $PATH nor has its default name. This is the default setting of yocto and open-embedded based systems. Please see do_install part in building script of it: > > https://github.com/openembedded/meta-oe/blob/master/meta-oe/recipes-core/llvm/llvm.inc well, that setup installs host backend only due to: --enable-targets=host-only in the above script, whereas typical clang install on ubuntu/fedora includes all backends. So in your case you'd need to install another clang. I agree that the name can be different than just 'clang', so yeah 'clang-path' is needed for this reason. So I'm ok keeping patches 23 and 24 as-is. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/