Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752021AbbFMGyh (ORCPT ); Sat, 13 Jun 2015 02:54:37 -0400 Received: from mail-wg0-f41.google.com ([74.125.82.41]:35498 "EHLO mail-wg0-f41.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751285AbbFMGy3 (ORCPT ); Sat, 13 Jun 2015 02:54:29 -0400 Date: Sat, 13 Jun 2015 08:54:24 +0200 From: Ingo Molnar To: Oleg Nesterov Cc: linux-kernel@vger.kernel.org, linux-mml@vger.kernel.org, Andy Lutomirski , Andrew Morton , Denys Vlasenko , Brian Gerst , Peter Zijlstra , Borislav Petkov , "H. Peter Anvin" , Linus Torvalds , Thomas Gleixner , Waiman Long Subject: Re: [PATCH 05/12] mm: Introduce arch_pgd_init_late() Message-ID: <20150613065424.GA16745@gmail.com> References: <1434031637-9091-1-git-send-email-mingo@kernel.org> <1434031637-9091-6-git-send-email-mingo@kernel.org> <20150612211220.GC18966@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150612211220.GC18966@redhat.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1228 Lines: 43 * Oleg Nesterov wrote: > On 06/11, Ingo Molnar wrote: > > > > @@ -1592,6 +1592,22 @@ static struct task_struct *copy_process(unsigned long clone_flags, > > syscall_tracepoint_update(p); > > write_unlock_irq(&tasklist_lock); > > > > + /* > > + * If we have a new PGD then initialize it: > > + * > > + * This method is called after a task has been made visible > > + * on the task list already. > > + * > > + * Architectures that manage per task kernel pagetables > > + * might use this callback to initialize them after they > > + * are already visible to new updates. > > + * > > + * NOTE: any user-space parts of the PGD are already initialized > > + * and must not be clobbered. > > + */ > > + if (p->mm != current->mm) > > + arch_pgd_init_late(p->mm, p->mm->pgd); > > + > > Cosmetic, but imo > > if (!(clone_flags & CLONE_VM)) > arch_pgd_init_late(...); > > will look better and more consistent. Indeed - fixed. Thanks, Ingo -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/