Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1752240AbbFMHvN (ORCPT <rfc822;w@1wt.eu>);
	Sat, 13 Jun 2015 03:51:13 -0400
Received: from mail-wi0-f182.google.com ([209.85.212.182]:36501 "EHLO
	mail-wi0-f182.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1751127AbbFMHvH (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Sat, 13 Jun 2015 03:51:07 -0400
Date: Sat, 13 Jun 2015 09:51:02 +0200
From: Ingo Molnar <mingo@kernel.org>
To: Oleg Nesterov <oleg@redhat.com>
Cc: linux-kernel@vger.kernel.org, linux-mml@vger.kernel.org,
        Andy Lutomirski <luto@amacapital.net>,
        Andrew Morton <akpm@linux-foundation.org>,
        Denys Vlasenko <dvlasenk@redhat.com>, Brian Gerst <brgerst@gmail.com>,
        Peter Zijlstra <peterz@infradead.org>, Borislav Petkov <bp@alien8.de>,
        "H. Peter Anvin" <hpa@zytor.com>,
        Linus Torvalds <torvalds@linux-foundation.org>,
        Thomas Gleixner <tglx@linutronix.de>, Waiman Long <Waiman.Long@hp.com>
Subject: Re: [PATCH 04/12] x86/mm/hotplug: Simplify sync_global_pgds()
Message-ID: <20150613075102.GD30388@gmail.com>
References: <1434031637-9091-1-git-send-email-mingo@kernel.org>
 <1434031637-9091-5-git-send-email-mingo@kernel.org>
 <20150612222830.GA23855@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20150612222830.GA23855@redhat.com>
User-Agent: Mutt/1.5.23 (2014-03-12)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 892
Lines: 30


* Oleg Nesterov <oleg@redhat.com> wrote:

> Yes I guess I am totally confused ;)
> 
> On 06/11, Ingo Molnar wrote:
> >
> > @@ -178,7 +178,7 @@ void sync_global_pgds(unsigned long start, unsigned long end, int removed)
> >  		 *
> >  		 * So clear the affected entries in every process PGD as well:
> >  		 */
> > -		if (pgd_none(*pgd_ref) && !removed)
> > +		if (pgd_none(*pgd_ref))
> 
> But doesn't this change invalidate the comment above?

Indeed - I fixed the comment to now say:

                /* Only sync (potentially) newly added PGD entries: */
                if (pgd_none(*pgd_ref))
                        continue;

Thanks,

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/