Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753181AbbFMK46 (ORCPT ); Sat, 13 Jun 2015 06:56:58 -0400 Received: from www.osadl.org ([62.245.132.105]:60826 "EHLO www.osadl.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751127AbbFMK4v (ORCPT ); Sat, 13 Jun 2015 06:56:51 -0400 From: Nicholas Mc Guire To: Samuel Ortiz Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [BUG ?] irda: via-ircc: condition with no effect Date: Sat, 13 Jun 2015 12:47:13 +0200 Message-Id: <1434192433-5934-1-git-send-email-hofrat@osadl.org> X-Mailer: git-send-email 1.7.10.4 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1307 Lines: 30 From: Nicholas Mc Guire scanning for trivial bug-patters with coccinelle spatches returned: ./drivers/net/irda/via-ircc.c:598 WARNING: condition with no effect (if branch == else) This code was added prior to the transition to git (Linux-2.6.12-rc2) so I was not really able to track back what the intent was. drivers/net/irda/via-ircc.c - line numbers from 4.1-rc7 598 if (IsSIROn(iobase)) { //sir 599 EnGPIOtoRX2(iobase, OFF); 600 WriteGIO(iobase, OFF); 601 EnRX2(iobase, OFF); //sir to rx2 602 } else { // fir mir 603 EnGPIOtoRX2(iobase, OFF); 604 WriteGIO(iobase, OFF); 605 EnRX2(iobase, OFF); //fir to rx 606 } Given the comments that indicate that the if/else case actually are different this may be a bug - if not the comments might need fixing. thx! hofrat -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/