Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753458AbbFMOUR (ORCPT ); Sat, 13 Jun 2015 10:20:17 -0400 Received: from atrey.karlin.mff.cuni.cz ([195.113.26.193]:33208 "EHLO atrey.karlin.mff.cuni.cz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751962AbbFMOUI (ORCPT ); Sat, 13 Jun 2015 10:20:08 -0400 Date: Sat, 13 Jun 2015 16:20:05 +0200 From: Pavel Machek To: Denys Vlasenko Cc: Brian Gerst , Ingo Molnar , "H. Peter Anvin" , Andy Lutomirski , Srinivas Pandruvada , Ingo Molnar , Thomas Gleixner , "Rafael J. Wysocki" , X86 ML , "linux-pm@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Denys Vlasenko , Borislav Petkov , Linus Torvalds Subject: Re: [PATCH] x86: General protection fault after STR (32 bit systems only) Message-ID: <20150613142005.GA29207@amd> References: <1434066338-6619-1-git-send-email-srinivas.pandruvada@linux.intel.com> <20150612060747.GA25024@gmail.com> <20150612075013.GA8759@gmail.com> <20150612083625.GA22760@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1337 Lines: 44 On Sat 2015-06-13 00:45:29, Denys Vlasenko wrote: > On Fri, Jun 12, 2015 at 5:48 PM, Brian Gerst wrote: > > If you follow the convoluted flow of the calls in this file, > > ... > > Speaking of which. It is indeed quite bad. > > For one, saved_eip is only ever set to point to ret_point: > > ENTRY(saved_eip) .long 0 > ... > > movl $ret_point, saved_eip > > and it has just a single user, where an indirect jump > through it is performed: > > # jump to place where we left off > movl saved_eip, %eax > jmp *%eax > > No comments why it is so. > > All this seems to be equivalent to trivial > > # jump to place where we left off > jmp ret_point > > Am I missing something? I don't think so. Its just that slowdown was not bad enough tofix it. ...patch would be welcome, and even better if you could check the issue on 64-bit kernel, too... Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/