Date: Sun, 14 Jun 2015 10:40:59 +0200
From: Ingo Molnar <mingo@kernel.org>
To: Denys Vlasenko <dvlasenk@redhat.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
        Steven Rostedt <rostedt@goodmis.org>, Borislav Petkov <bp@alien8.de>,
        "H. Peter Anvin" <hpa@zytor.com>,
        Andy Lutomirski <luto@amacapital.net>, Oleg Nesterov <oleg@redhat.com>,
        Frederic Weisbecker <fweisbec@gmail.com>,
        Alexei Starovoitov <ast@plumgrid.com>, Will Drewry <wad@chromium.org>,
        Kees Cook <keescook@chromium.org>, x86@kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH 4/5] x86/asm/entry/32: Replace RESTORE_RSI_RDI[_RDX] with
 open-coded 32-bit reads
Message-ID: <20150614084059.GA24562@gmail.com>
References: <1433876051-26604-1-git-send-email-dvlasenk@redhat.com>
 <1433876051-26604-4-git-send-email-dvlasenk@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1433876051-26604-4-git-send-email-dvlasenk@redhat.com>
User-Agent: Mutt/1.5.23 (2014-03-12)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1056
Lines: 40


* Denys Vlasenko <dvlasenk@redhat.com> wrote:

> 	+8b 74 24 68            mov    0x68(%rsp),%esi
> 	+8b 7c 24 70            mov    0x70(%rsp),%edi
> 	+8b 54 24 60            mov    0x60(%rsp),%edx

Btw., could you (in another patch) order the restoration properly, by pt_regs 
memory order, where possible?

So this:

> +	movl	RSI(%rsp), %esi
> +	movl	RDI(%rsp), %edi
> +	movl	RDX(%rsp), %edx
>  	movl	RIP(%rsp), %ecx
>  	movl	EFLAGS(%rsp), %r11d

would become:

	movl	RDX(%rsp), %edx
	movl	RSI(%rsp), %esi
	movl	RDI(%rsp), %edi
	movl	RIP(%rsp), %ecx
 	movl	EFLAGS(%rsp), %r11d

... or so.

In fact I'd suggest we structure movl based restoration precisely after the field 
order in the structure, and comment on cases where we depart from what's in 
pt_regs - to make it all easier to verify.

Thanks,

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/