Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751979AbbFNMuO (ORCPT ); Sun, 14 Jun 2015 08:50:14 -0400 Received: from mx1.redhat.com ([209.132.183.28]:58680 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751408AbbFNMuF (ORCPT ); Sun, 14 Jun 2015 08:50:05 -0400 Message-ID: <557D7878.5000105@redhat.com> Date: Sun, 14 Jun 2015 14:50:00 +0200 From: Denys Vlasenko User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.2.0 MIME-Version: 1.0 To: Ingo Molnar CC: Linus Torvalds , Steven Rostedt , Borislav Petkov , "H. Peter Anvin" , Andy Lutomirski , Oleg Nesterov , Frederic Weisbecker , Alexei Starovoitov , Will Drewry , Kees Cook , x86@kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] x86/asm/entry/32, selftests: Add test_syscall_vdso test References: <1434122983-12337-1-git-send-email-dvlasenk@redhat.com> <20150613063941.GA13398@gmail.com> In-Reply-To: <20150613063941.GA13398@gmail.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1208 Lines: 32 On 06/13/2015 08:39 AM, Ingo Molnar wrote: > > * Denys Vlasenko wrote: > >> The test is fairly simplistic: it checks that all registers >> are preserved across 32-bit syscall via VDSO. >> >> Run-tested: >> >> $ ./test_syscall_vdso_32 >> [RUN] Executing 6-argument 32-bit syscall via VDSO >> [Ok] Arguments are preserved across syscall >> [RUN] Executing 6-argument 32-bit syscall via INT 80 >> [Ok] Arguments are preserved across syscall >> [RUN] Running tests under ptrace >> [RUN] Executing 6-argument 32-bit syscall via VDSO >> [Ok] Arguments are preserved across syscall >> [RUN] Executing 6-argument 32-bit syscall via INT 80 >> [Ok] Arguments are preserved across syscall > > Just curious: is there a kernel sha1 where this test would fail? Or did you try to > provoke an information leak perhaps? I did see failures, more than once, when testing my own patches. I'm not aware of released kernels which are buggy wrt this test. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/