Message-ID: <557D9B09.7020100@lwfinger.net>
Date: Sun, 14 Jun 2015 10:17:29 -0500
From: Larry Finger <Larry.Finger@lwfinger.net>
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0
MIME-Version: 1.0
To: Nicholas Mc Guire <hofrat@osadl.org>
CC: Chaoming Li <chaoming_li@realsil.com.cn>,
        Kalle Valo <kvalo@codeaurora.org>,
        "John W. Linville" <linville@tuxdriver.com>,
        Jiri Kosina <jkosina@suse.cz>, Randy Dunlap <rdunlap@infradead.org>,
        Masanari Iida <standby24x7@gmail.com>, linux-wireless@vger.kernel.org,
        netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [BUG ?] rtlwifi: rtl8723be: condition with no effect
References: <1434192211-5855-1-git-send-email-hofrat@osadl.org>
In-Reply-To: <1434192211-5855-1-git-send-email-hofrat@osadl.org>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1308
Lines: 34

On 06/13/2015 05:43 AM, Nicholas Mc Guire wrote:
> From: Nicholas Mc Guire <hofrat@osadl.org>
>
> scanning for trivial bug-patters with coccinelle spatches returned:
> ./drivers/net/wireless/rtlwifi/rtl8723be/dm.c:886
> 	WARNING: condition with no effect (if branch == else)
>
> Added in 'commit a619d1abe20c ("rtlwifi: rtl8723be: Add new driver")'
>
> drivers/net/wireless/rtlwifi/rtl8723be/dm.c - line numbers from 4.1-rc7
> 886         if (thermalvalue > rtlefuse->eeprom_thermalmeter)
> 887                 rtl8723be_dm_tx_power_track_set_power(hw, BBSWING, 0,
> 888						 	index_for_channel);
> 889         else
> 890                 rtl8723be_dm_tx_power_track_set_power(hw, BBSWING, 0,
> 891							index_for_channel);
>
> Can't figure out what the intent of this condition is but it currently has
> no effect as if == else and this most likely is not the intent.

I do not know what the correct code should be here, but I will contact the 
Realtek engineers and get their interpretation. In the meantime, please do not 
change this code.

Thanks,

Larry


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/