Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752321AbbFNQol (ORCPT ); Sun, 14 Jun 2015 12:44:41 -0400 Received: from mail-wi0-f177.google.com ([209.85.212.177]:34563 "EHLO mail-wi0-f177.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751475AbbFNQod (ORCPT ); Sun, 14 Jun 2015 12:44:33 -0400 Date: Sun, 14 Jun 2015 09:44:22 -0700 (PDT) From: Hugh Dickins X-X-Sender: hugh@eggly.anvils To: Prarit Bhargava cc: Hugh Dickins , Morten Stevens , Daniel Wagner , Dave Chinner , Eric Paris , Eric Sandeen , Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: linux 4.1-rc7 deadlock In-Reply-To: <557A089A.3090202@redhat.com> Message-ID: References: <5576D3E7.40302@fedoraproject.org> <5576F3DA.7000106@monom.org> <557A089A.3090202@redhat.com> User-Agent: Alpine 2.11 (LSU 23 2013-08-11) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2006 Lines: 53 On Thu, 11 Jun 2015, Prarit Bhargava wrote: > On 06/11/2015 04:06 PM, Hugh Dickins wrote: > > On Tue, 9 Jun 2015, Morten Stevens wrote: > >> 2015-06-09 16:10 GMT+02:00 Daniel Wagner : > >>> On 06/09/2015 01:54 PM, Morten Stevens wrote: > > > > Reported-by: Prarit Bhargava > > Reported-by: Daniel Wagner > > Reported-by: Morten Stevens > > Not-Yet-Signed-off-by: Hugh Dickins > > --- > > > > mm/shmem.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > --- 4.1-rc7/mm/shmem.c 2015-04-26 19:16:31.352191298 -0700 > > +++ linux/mm/shmem.c 2015-06-11 11:08:21.042745594 -0700 > > @@ -3401,7 +3401,7 @@ int shmem_zero_setup(struct vm_area_stru > > struct file *file; > > loff_t size = vma->vm_end - vma->vm_start; > > > > - file = shmem_file_setup("dev/zero", size, vma->vm_flags); > > + file = __shmem_file_setup("dev/zero", size, vma->vm_flags, S_PRIVATE); > > Perhaps, > > file = shmem_kernel_file_setup("dev/zero", size, vma->vm_flags) ? Perhaps. I couldn't decide whether this is a proper intended use of shmem_kernel_file_setup(), or a handy reuse of its flag. Andrew asked for a comment, so in the end I left that line as is, but refer to shmem_kernel_file_setup() in the comment. And that forced me to look a little closer at the security implications: but we do seem to be safe. > > Tested-by: Prarit Bhargava Thank you: I had been hoping for some corroboration from one of the other guys (no offence to you, but 33% looks a bit weak!), but now it's Sunday so I think I'd better send this off in the hope that it makes -rc8. Hugh > > P. > > > if (IS_ERR(file)) > > return PTR_ERR(file); -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/