Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752586AbbFNTxI (ORCPT ); Sun, 14 Jun 2015 15:53:08 -0400 Received: from isilmar-3.linta.de ([188.40.101.200]:36800 "EHLO linta.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751060AbbFNTw6 (ORCPT ); Sun, 14 Jun 2015 15:52:58 -0400 Date: Sun, 14 Jun 2015 21:37:55 +0200 From: Dominik Brodowski To: Takeshi Yoshimura Cc: Greg Kroah-Hartman , Vaishali Thakkar , linux-pcmcia@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/1] pcmcia: Fix resource leaks in yenta_probe() and _close() Message-ID: <20150614193755.GA13291@light.dominikbrodowski.net> References: <1434303839-2146-1-git-send-email-yos@sslab.ics.keio.ac.jp> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="zhXaljGHf11kAtnf" Content-Disposition: inline In-Reply-To: <1434303839-2146-1-git-send-email-yos@sslab.ics.keio.ac.jp> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2021 Lines: 54 --zhXaljGHf11kAtnf Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Jun 15, 2015 at 02:43:59AM +0900, Takeshi Yoshimura wrote: > There are some resource leaks in yenta_probe() and _close(). I fixed > the following issues with some code cleanups. Thanks to Dominik's > suggestions. >=20 > On the error path in yenta_probe(): > - a requested irq is not released > - yenta_free_resources() and pci_set_drvdata(dev, NULL) are not called >=20 > In yenta_close(): > - kfree(sock) is not called > - sock->base is always set to non-NULL when yenta_close() is called, > therefore the check in yenta_close() is not necessary. >=20 > Signed-off-by: Takeshi Yoshimura Applied to the PCMCIA tree. Many thanks! Dominik --zhXaljGHf11kAtnf Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJVfdgTAAoJEJqXYIlMjaMNgpMP/iQCdfv7OveMBiuJuK25S1yl 30ma8yiOpu/sR2KQnWmU31mWVv2hs3rsnCT43qG2mY5zTwqqNuoXbIqVjpJD+ZJX Fz1Qia0Sj7sSLbTukCevb72FMdIstqXQ+A0anvtNVLdPOilclsdzY5crn/5+vTgi 6cia1xiYyvlduCv5XGhxONwv2aoi+4JgYmZDVGXLUxoaV9JANpk9usWLqq+vheK7 Gv7D60coDPnO0HPLfIXOPQRv/nyklT1JdiMNn+POQSSIVOjQoIaIzvA2acoQUGZj TohNes/2Gnj1jtqrdx24xj0awo6IS4wty7G1S4MKf/xAsSsW3/GEmIKUOt8pnhLT x1KDEJDSnXIOKIejRS3flQMj9SUWIp5RfH0A0fxHOalXy8qXC5o9J+ag72Wu/HOh /bFGDTiteg4sx1qzbbTHH7Tj29zGuv7S3V0VZlD2KykuUC/LLTo2QX5iWQWO7DGA 0ZGIIzhFz1RJ4jJWBn/uABsLT9NYGG2uYY2HQcOiB1vsgz55+BGIe1X1Q9ONC4t7 OE+3SB4ABl80uTsplORV6evavCCXmwxQ6q5C0Xgsbxy75rSlP/P0x9AHM875cwAE 2CnLDxvLeZsQ3f9Rd56dhtoMlUmciwscy9f77YIyix0mEXgMz5dOo7YSMK6lkIOf XogR7hwUfEQsgLwvqdtm =ErSe -----END PGP SIGNATURE----- --zhXaljGHf11kAtnf-- -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/