Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753083AbbFOAvp (ORCPT ); Sun, 14 Jun 2015 20:51:45 -0400 Received: from mail-wg0-f52.google.com ([74.125.82.52]:34846 "EHLO mail-wg0-f52.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752346AbbFOAvh (ORCPT ); Sun, 14 Jun 2015 20:51:37 -0400 MIME-Version: 1.0 In-Reply-To: <20150612094509.GC19400@ulmo.nvidia.com> References: <1432670900-27687-1-git-send-email-jonathar@broadcom.com> <1432670900-27687-2-git-send-email-jonathar@broadcom.com> <20150612094509.GC19400@ulmo.nvidia.com> Date: Sun, 14 Jun 2015 17:51:35 -0700 Message-ID: Subject: Re: [PATCH v8 1/5] drivers: pwm: core: Add pwmchip_add_inversed From: Tim Kryger To: Thierry Reding Cc: Jonathan Richardson , Dmitry Torokhov , Anatol Pomazau , Arun Ramamurthy , Scott Branden , bcm-kernel-feedback-list , Linux Kernel Mailing List , Linux PWM Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1295 Lines: 32 On Fri, Jun 12, 2015 at 2:45 AM, Thierry Reding wrote: > On Tue, May 26, 2015 at 01:08:16PM -0700, Jonathan Richardson wrote: >> From: Tim Kryger >> >> Add a new function to register a PWM chip with channels that have their >> initial polarity as inversed. This benefits drivers of controllers that >> by default operate with inversed polarity by removing the need to modify >> the polarity during initialization. >> >> Signed-off-by: Tim Kryger >> Signed-off-by: Jonathan Richardson >> --- >> drivers/pwm/core.c | 36 ++++++++++++++++++++++++++++-------- >> include/linux/pwm.h | 6 ++++++ >> 2 files changed, 34 insertions(+), 8 deletions(-) > > I had to bikeshed this a little, so I ended up applying a variant that > exports pwmchip_add_with_polarity() instead of having the additional > wrapper. The rationale here is that pwmchip_add_with_polarity() is more > explicit than pwmchip_add_inversed(). > > Thierry Sounds good. Thanks. -Tim -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/