Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753499AbbFOHfL (ORCPT ); Mon, 15 Jun 2015 03:35:11 -0400 Received: from bastet.se.axis.com ([195.60.68.11]:41761 "EHLO bastet.se.axis.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752759AbbFOHfF (ORCPT ); Mon, 15 Jun 2015 03:35:05 -0400 Date: Mon, 15 Jun 2015 09:35:01 +0200 From: Jesper Nilsson To: Paul Gortmaker Cc: linux-kernel@vger.kernel.org, Mikael Starvik , Jesper Nilsson , linux-cris-kernel@axis.com Subject: Re: [PATCH] cris: don't use module_init for non-modular core eeprom.c code Message-ID: <20150615073501.GO26605@axis.com> References: <1434315921-1198-1-git-send-email-paul.gortmaker@windriver.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1434315921-1198-1-git-send-email-paul.gortmaker@windriver.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1413 Lines: 33 On Sun, Jun 14, 2015 at 05:05:21PM -0400, Paul Gortmaker wrote: > The eeprom.c code is compiled based on the Kconfig setting > ETRAX_I2C_EEPROM, which is bool. So the code is either built in > or absent. It will never be modular, so using module_init as an > alias for __initcall is rather misleading. > > Fix this up now, so that we can relocate module_init from > init.h into module.h in the future. If we don't do this, we'd > have to add module.h to obviously non-modular code, and that > would be a worse thing. > > Direct use of __initcall is discouraged, vs prioritized ones. > Use of device_initcall is consistent with what __initcall > maps onto, and hence does not change the init order, making the > impact of this change zero. Should someone with real hardware > for boot testing want to change it later to arch_initcall or > something different, they can do that at a later date. > > Cc: Mikael Starvik Looks good, I'll take it in the CRIS-tree. > Cc: linux-cris-kernel@axis.com > Signed-off-by: Paul Gortmaker /^JN - Jesper Nilsson -- Jesper Nilsson -- jesper.nilsson@axis.com -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/