Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754002AbbFOHgN (ORCPT ); Mon, 15 Jun 2015 03:36:13 -0400 Received: from mail-lb0-f173.google.com ([209.85.217.173]:35563 "EHLO mail-lb0-f173.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751554AbbFOHgD convert rfc822-to-8bit (ORCPT ); Mon, 15 Jun 2015 03:36:03 -0400 Date: Mon, 15 Jun 2015 10:42:13 +0300 From: Antony Pavlov To: Alban Cc: linux-mips@linux-mips.org, Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , Thomas Gleixner , Jason Cooper , Ralf Baechle , Andrew Bresticker , Qais Yousef , Gabor Juhos , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v4 12/12] MIPS: Add basic support for the TL-WR1043ND version 1 Message-Id: <20150615104213.92258d2d0616c12e4aa7bf1a@gmail.com> In-Reply-To: <20150610235811.0b18af9b@tock> References: <1433029955-7346-1-git-send-email-albeu@free.fr> <1433031506-7984-5-git-send-email-albeu@free.fr> <20150608131758.9d76be074998ea3de0e976a4@gmail.com> <20150610235811.0b18af9b@tock> X-Mailer: Sylpheed 3.5.0beta1 (GTK+ 2.24.25; i586-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1779 Lines: 66 On Wed, 10 Jun 2015 23:58:11 +0200 Alban wrote: > On Mon, 8 Jun 2015 13:17:58 +0300 > Antony Pavlov wrote: > > > IMHO AR9132 SoC can't work without external oscilator. > > > > Can we just move basic extosc declaration to SoC dt file > > (ar9132.dtsi)? So board dt file ar9132_tl_wr1043nd_v1.dts will > > contain only oscilator clock frequency value. > > I would prefer to keep the split between the files in sync with the > hardware. I understand that most simple board designs use a fixed > oscillator, but that might not always be the case. > The AR9132 SoC __always__ use one external oscilator. So it's reasonable to have the first mention of extosc in ar9132.dtsi not in a board file. This description style is always sync with hardware. On the other hand pll-controller is always part of the SoC not a part of a board. So pll-controller on extosc dependency have to go to SoC dts file not to a board file. In your dts description pll-controller is a part of a dts board file. It looks like my previous device tree structure proposal contains a small error (extra clock-frequency field in ar9132.dtsi). I have fixed it. Please comment it. ar9132.dtsi: ============ extosc: oscillator { compatible = "fixed-clock"; #clock-cells = <0>; }; ... ahb { apb { ... pll-controller@18050000 { ... clocks = <&extosc>; ... ar9132_tl_wr1043nd_v1.dts: ========================== ... &extosc { clock-frequency = <40000000>; }; -- --? Best regards, ? Antony Pavlov -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/