Date: Mon, 15 Jun 2015 17:28:48 +0800
From: Dave Young <dyoung@redhat.com>
To: Minfei Huang <mhuang@redhat.com>
Cc: ebiederm@xmission.com, vgoyal@redhat.com, kexec@lists.infradead.org,
        linux-kernel@vger.kernel.org, Minfei Huang <mnfhuang@gmail.com>
Subject: Re: [PATCH] kexec: Remove the unnecessary conditional judgement to
 simplify the code logic
Message-ID: <20150615092848.GB15858@dhcp-128-59.nay.redhat.com>
References: <1433571252-11874-1-git-send-email-mhuang@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1433571252-11874-1-git-send-email-mhuang@redhat.com>
User-Agent: Mutt/1.5.22.1-rc1 (2013-10-16)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1271
Lines: 39

On 06/06/15 at 02:14pm, Minfei Huang wrote:
> From: Minfei Huang <mnfhuang@gmail.com>
> 
> Transforming PFN(Page Frame Number) to struct page is never failure, so
> we can simplify the code logic to do the image->control_page assignment
> directly in the loop, and remove the unnecessary conditional judgement.
> 
> Signed-off-by: Minfei Huang <mnfhuang@gmail.com>
> ---
>  kernel/kexec.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/kernel/kexec.c b/kernel/kexec.c
> index 7a36fdc..4589899 100644
> --- a/kernel/kexec.c
> +++ b/kernel/kexec.c
> @@ -796,11 +796,10 @@ static struct page *kimage_alloc_crash_control_pages(struct kimage *image,
>  		/* If I don't overlap any segments I have found my hole! */
>  		if (i == image->nr_segments) {
>  			pages = pfn_to_page(hole_start >> PAGE_SHIFT);
> +			image->control_page = hole_end;
>  			break;
>  		}
>  	}
> -	if (pages)
> -		image->control_page = hole_end;
>  
>  	return pages;
>  }

Acked-by: Dave Young <dyoung@redhat.com>

Thanks
Dave
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/