Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754138AbbFOJ3U (ORCPT ); Mon, 15 Jun 2015 05:29:20 -0400 Received: from mga01.intel.com ([192.55.52.88]:61125 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754091AbbFOJ3I (ORCPT ); Mon, 15 Jun 2015 05:29:08 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.13,618,1427785200"; d="scan'208";a="746839952" Date: Mon, 15 Jun 2015 12:29:03 +0300 From: Mika Westerberg To: Lucas De Marchi Cc: linux-i2c@vger.kernel.org, lkml , Wolfram Sang , Jarkko Nikula , Fabio Mello , Lucas De Marchi Subject: Re: [PATCH] i2c: designware: use enable on resume instead initialization Message-ID: <20150615092903.GG1478@lahna.fi.intel.com> References: <1433785828-4100-1-git-send-email-lucas.de.marchi@gmail.com> <20150610075555.GO1478@lahna.fi.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 972 Lines: 24 On Fri, Jun 12, 2015 at 07:45:00PM -0300, Lucas De Marchi wrote: > Hi Mika, > > On Wed, Jun 10, 2015 at 4:55 AM, Mika Westerberg > wrote: > > On Mon, Jun 08, 2015 at 02:50:28PM -0300, lucas.de.marchi@gmail.com wrote: > >> @@ -320,7 +320,7 @@ static int dw_i2c_resume(struct device *dev) > >> clk_prepare_enable(i_dev->clk); > >> > >> if (!i_dev->pm_runtime_disabled) > >> - i2c_dw_init(i_dev); > >> + i2c_dw_enable(i_dev); > > > > This will not work if the device power gets removed (for example being > > put to D3cold) as it looses context. > > Do you mean we should keep the i2c_dw_init() here? Yes, that's safer if the controller power gets removed. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/