Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754787AbbFOJtx (ORCPT ); Mon, 15 Jun 2015 05:49:53 -0400 Received: from mezzanine.sirena.org.uk ([106.187.55.193]:58118 "EHLO mezzanine.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754135AbbFOJtp (ORCPT ); Mon, 15 Jun 2015 05:49:45 -0400 Date: Mon, 15 Jun 2015 10:49:22 +0100 From: Mark Brown To: Sergej Sawazki Cc: gregkh@linuxfoundation.org, w.sang@pengutronix.de, wsa@the-dreams.de, linux-kernel@vger.kernel.org Message-ID: <20150615094922.GB18309@sirena.org.uk> References: <557C2E3E.80000@gmx.de> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="GRPZ8SYKNexpdSJ7" Content-Disposition: inline In-Reply-To: <557C2E3E.80000@gmx.de> X-Cookie: do { User-Agent: Mutt/1.5.23 (2014-03-12) X-SA-Exim-Connect-IP: 81.129.82.198 X-SA-Exim-Mail-From: broonie@sirena.org.uk Subject: Re: [BUG ?] regmap: debugfs: WARN_ON at regmap-debugfs.c:151 X-SA-Exim-Version: 4.2.1 (built Mon, 26 Dec 2011 16:24:06 +0000) X-SA-Exim-Scanned: Yes (on mezzanine.sirena.org.uk) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1838 Lines: 46 --GRPZ8SYKNexpdSJ7 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Sat, Jun 13, 2015 at 03:21:02PM +0200, Sergej Sawazki wrote: > when I try to read the register values of a i2c ASoC codec through > debugfs, (eg: cat /sys/kernel/debug/regmap/1-001a/registers) > I am getting an WARN_ON at drivers/base/regmap/regmap-debugfs.c:151. Please provide some plain text description of which line of code you're referring to when reporting things - line numbers do change as things move on (though I see this one). > I did some debugging and found that regmap_readable(), at regmap- > debugfs.c:109, returns "false" for all registers, hence the > debugfs_off_cache list remains empty and we get an warning in line 151. We need to change that code to special case write only register maps like this and just skip having a cache for those devices. They normally have very small register maps anyway so it shouldn't have too big an impact on performance. --GRPZ8SYKNexpdSJ7 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJVfp+hAAoJECTWi3JdVIfQ7nMH/0Zra80qQjoXTobTBB8PY+2H fX69xr5WGy+8Efx3m+F+b2kMaGpxSKRn+Nx+WY97XhEg2YC0IL6cbHqKkh6p6LL4 x7ysIbzPg2qFBSg0h3V03yTP5yDFh/SlWFtDXjALt8rntcJKh7UduTjPg8yO3HP7 7oNzxkQhs4TsRS6HntXmHZJG3XxS1B5Viu9J2cdwwocLY16qKLW9C0x7m3MVGg0l LU9GhAOLPCEXdGBLiNVlUvrt0ktpFSlHrIbJVbNDNXjAKDGgXuGadxEHAW4U15qA 2sLm2dOJSBecbVSFifm432DrEMwEDasdz/pSQM6Pq7t+IKfZ7mGxxzPetKRoppw= =am1G -----END PGP SIGNATURE----- --GRPZ8SYKNexpdSJ7-- -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/