Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755564AbbFOJym (ORCPT ); Mon, 15 Jun 2015 05:54:42 -0400 Received: from mail-qk0-f174.google.com ([209.85.220.174]:34345 "EHLO mail-qk0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754174AbbFOJyd (ORCPT ); Mon, 15 Jun 2015 05:54:33 -0400 MIME-Version: 1.0 In-Reply-To: <1433953854-23343-1-git-send-email-fabf@skynet.be> References: <1433953854-23343-1-git-send-email-fabf@skynet.be> Date: Mon, 15 Jun 2015 11:54:32 +0200 Message-ID: Subject: Re: [PATCH 1/1 linux-next] mmc: queue: use swap() in mmc_queue_thread() From: Ulf Hansson To: Fabian Frederick Cc: "linux-kernel@vger.kernel.org" , Julia Lawall , linux-mmc Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1598 Lines: 47 On 10 June 2015 at 18:30, Fabian Frederick wrote: > Use kernel.h macro definition. > > Thanks to Julia Lawall for Coccinelle scripting support. > > Signed-off-by: Fabian Frederick Thanks, applied. Kind regards Uffe > --- > drivers/mmc/card/queue.c | 5 +---- > 1 file changed, 1 insertion(+), 4 deletions(-) > > diff --git a/drivers/mmc/card/queue.c b/drivers/mmc/card/queue.c > index 8efa368..d34e09b 100644 > --- a/drivers/mmc/card/queue.c > +++ b/drivers/mmc/card/queue.c > @@ -56,7 +56,6 @@ static int mmc_queue_thread(void *d) > down(&mq->thread_sem); > do { > struct request *req = NULL; > - struct mmc_queue_req *tmp; > unsigned int cmd_flags = 0; > > spin_lock_irq(q->queue_lock); > @@ -86,9 +85,7 @@ static int mmc_queue_thread(void *d) > > mq->mqrq_prev->brq.mrq.data = NULL; > mq->mqrq_prev->req = NULL; > - tmp = mq->mqrq_prev; > - mq->mqrq_prev = mq->mqrq_cur; > - mq->mqrq_cur = tmp; > + swap(mq->mqrq_prev, mq->mqrq_cur); > } else { > if (kthread_should_stop()) { > set_current_state(TASK_RUNNING); > -- > 2.4.2 > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/