Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755929AbbFOJ4p (ORCPT ); Mon, 15 Jun 2015 05:56:45 -0400 Received: from cantor2.suse.de ([195.135.220.15]:36841 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755828AbbFOJzs (ORCPT ); Mon, 15 Jun 2015 05:55:48 -0400 Date: Mon, 15 Jun 2015 11:55:46 +0200 From: Johannes Thumshirn To: Sreekanth Reddy Cc: jejb@kernel.org, hch@infradead.org, martin.petersen@oracle.com, linux-scsi@vger.kernel.org, JBottomley@Parallels.com, Sathya.Prakash@avagotech.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH 18/20] [SCSI] mpt3sas: Call dma_mapping_error() API after mapping an address with dma_map_single() API Message-ID: <20150615095546.GI5660@c203.arch.suse.de> References: <1434102153-38581-1-git-send-email-Sreekanth.Reddy@avagotech.com> <1434102153-38581-19-git-send-email-Sreekanth.Reddy@avagotech.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1434102153-38581-19-git-send-email-Sreekanth.Reddy@avagotech.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2367 Lines: 54 On Fri, Jun 12, 2015 at 03:12:30PM +0530, Sreekanth Reddy wrote: > Added dma_mapping_error() API after mapping an address with dma_map_single() API. > Otherwise when CONFIG_DMA_API_DEBUG is enabled in the kernel, then it complains > about mpt3sas driver not calling dma_mapping_error after mapping an address with > dma_map_single > > Signed-off-by: Sreekanth Reddy > --- > drivers/scsi/mpt3sas/mpt3sas_transport.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/scsi/mpt3sas/mpt3sas_transport.c b/drivers/scsi/mpt3sas/mpt3sas_transport.c > index 7a7aa68..70fd019 100644 > --- a/drivers/scsi/mpt3sas/mpt3sas_transport.c > +++ b/drivers/scsi/mpt3sas/mpt3sas_transport.c > @@ -1964,7 +1964,7 @@ _transport_smp_handler(struct Scsi_Host *shost, struct sas_rphy *rphy, > } else { > dma_addr_out = pci_map_single(ioc->pdev, bio_data(req->bio), > blk_rq_bytes(req), PCI_DMA_BIDIRECTIONAL); > - if (!dma_addr_out) { > + if (pci_dma_mapping_error(ioc->pdev, dma_addr_out)) { > pr_info(MPT3SAS_FMT "%s(): DMA Addr out = NULL\n", > ioc->name, __func__); > rc = -ENOMEM; > @@ -1986,7 +1986,7 @@ _transport_smp_handler(struct Scsi_Host *shost, struct sas_rphy *rphy, > } else { > dma_addr_in = pci_map_single(ioc->pdev, bio_data(rsp->bio), > blk_rq_bytes(rsp), PCI_DMA_BIDIRECTIONAL); > - if (!dma_addr_in) { > + if (pci_dma_mapping_error(ioc->pdev, dma_addr_in)) { > pr_info(MPT3SAS_FMT "%s(): DMA Addr in = NULL\n", > ioc->name, __func__); > rc = -ENOMEM; > -- > 2.0.2 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-scsi" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html Reviewed-by: Johannes Thumshirn -- Johannes Thumshirn Storage jthumshirn@suse.de +49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 N?rnberg GF: F. Imend?rffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton HRB 21284 (AG N?rnberg) -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/