Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754869AbbFOK4k (ORCPT ); Mon, 15 Jun 2015 06:56:40 -0400 Received: from mail-wg0-f45.google.com ([74.125.82.45]:34236 "EHLO mail-wg0-f45.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754135AbbFOK4b (ORCPT ); Mon, 15 Jun 2015 06:56:31 -0400 MIME-Version: 1.0 In-Reply-To: <557B4923.1020608@stratus.com> References: <1434102153-38581-1-git-send-email-Sreekanth.Reddy@avagotech.com> <1434102153-38581-18-git-send-email-Sreekanth.Reddy@avagotech.com> <557B4923.1020608@stratus.com> Date: Mon, 15 Jun 2015 16:26:29 +0530 Message-ID: Subject: Re: [PATCH 17/20] [SCSI] mpt3sas: Use alloc_ordered_workqueue() API instead of create_singlethread_workqueue() API From: Sreekanth Reddy To: Joe Lawrence Cc: "jejb@kernel.org" , Christoph Hellwig , "Martin K. Petersen" , "linux-scsi@vger.kernel.org" , "James E.J. Bottomley" , Sathya Prakash , "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1083 Lines: 38 On Sat, Jun 13, 2015 at 2:33 AM, Joe Lawrence wrote: > On 06/12/2015 05:42 AM, Sreekanth Reddy wrote: > ... >> +#if defined(alloc_ordered_workqueue) >> + ioc->firmware_event_thread = alloc_ordered_workqueue( >> + ioc->firmware_event_name, WQ_MEM_RECLAIM); >> +#else >> + ioc->firmware_event_thread = create_singlethread_workqueue( >> ioc->firmware_event_name); >> +#endif > > Hi Sreekanth, > > I think the upstream version of this code can safely assume > alloc_ordered_workqueue is defined, no? yes, upstream version of this code can safely assume that alloc_ordered_workqueue is defined. While working in-house, I observed that some of the older kernels doesn't defined this macro, so I have added this else section. > > Regards, > > -- Joe -- Regards, Sreekanth -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/