Message-ID: <1434370255.25843.8.camel@linux.intel.com>
Subject: Re: [PATCH 4/5] pcmcia: handle anonymous cards by generating a fake
 CIS
From: Alan Cox <alan@linux.intel.com>
To: Dominik Brodowski <linux@dominikbrodowski.net>
Cc: linux-kernel@vger.kernel.org, linux-pcmica@lists.infradead.org
Date: Mon, 15 Jun 2015 13:10:55 +0100
In-Reply-To: <20150614195246.GA13314@light.dominikbrodowski.net>
References: <20141204212746.1351.89165.stgit@localhost.localdomain>
	 <20141204213015.1351.23846.stgit@localhost.localdomain>
	 <20150614195246.GA13314@light.dominikbrodowski.net>
Organization: Intel Corporation
Content-Type: text/plain; charset="UTF-8"
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1009
Lines: 24

> Unfortunately, this patch does not work well with all of the callers of
> pccard_validate_cis(). While it helps for ds.c:pcmcia_card_add() and does
> not matter for cistpl.c:pccard_show_cis(), it breaks the callback in
> rsrc_nonstatic.c:readable():

I'm not sure it's the right way to do readable() but we seem to be stuck
with that anyway.

The change looks good to me, and I will try and test it soon but it may
take some time due to various other things going on in life. Can you
submit it for 4.2 anyway and give it a bit of time for any screaming
then push to stable ? The number of people using anonymous cards is
pretty small these days so I think it's better to fix the regression you
have and worry about anonymous cards as a secondary thing.

Alan


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/