Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754570AbbFOMnB (ORCPT ); Mon, 15 Jun 2015 08:43:01 -0400 Received: from mout.gmx.net ([212.227.17.20]:54703 "EHLO mout.gmx.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754170AbbFOMmx convert rfc822-to-8bit (ORCPT ); Mon, 15 Jun 2015 08:42:53 -0400 User-Agent: K-9 Mail for Android In-Reply-To: <20150615094922.GB18309@sirena.org.uk> References: <557C2E3E.80000@gmx.de> <20150615094922.GB18309@sirena.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Subject: Re: [BUG ?] regmap: debugfs: WARN_ON at regmap-debugfs.c:151 From: Sergej Sawazki Date: Mon, 15 Jun 2015 14:42:30 +0200 To: Mark Brown CC: gregkh@linuxfoundation.org, wsa@the-dreams.de, linux-kernel@vger.kernel.org Message-ID: X-Provags-ID: V03:K0:6dlUXJU5L5Q3bTJb5jShkn2/KCGbpIhxyFNumpJkrJn7Cn6ckET i0QJOB+M6XEJAnJoafClchh2cnfRHsKwhBrjt/mO6Uy/XgkoxPMiRJIkcCVH/7sEq9+jKdM 0Yn3Eb0wOhJ2vcamqbYnWcvJQc8GjqEJXbMbvTFxi14pBzM5FGhghplvBpfehFd9dTT87Hy kvu1x/kcYSWqGKPRP9Lag== X-UI-Out-Filterresults: notjunk:1; Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 969 Lines: 25 Am 15. Juni 2015 11:49:22 MESZ, schrieb Mark Brown : >On Sat, Jun 13, 2015 at 03:21:02PM +0200, Sergej Sawazki wrote: > >> I did some debugging and found that regmap_readable(), at regmap- >> debugfs.c:109, returns "false" for all registers, hence the >> debugfs_off_cache list remains empty and we get an warning in line >151. > >We need to change that code to special case write only register maps >like this and just skip having a cache for those devices. They >normally >have very small register maps anyway so it shouldn't have too big an >impact on performance. I'm having this issue with a wm8741 DAC, its register map is not "write only", it has readable and writeable registers. -- Sergej -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/