Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755378AbbFOMoZ (ORCPT ); Mon, 15 Jun 2015 08:44:25 -0400 Received: from mail-by2on0135.outbound.protection.outlook.com ([207.46.100.135]:45768 "EHLO na01-by2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1754031AbbFOMoR (ORCPT ); Mon, 15 Jun 2015 08:44:17 -0400 From: Madalin-Cristian Bucur To: Eric Dumazet CC: "linux-kernel@vger.kernel.org" , Jianhua Xie , "netdev@vger.kernel.org" , "linuxppc-dev@lists.ozlabs.org" Subject: RE: [RFC,v3 02/10] dpaa_eth: add support for DPAA Ethernet Thread-Topic: [RFC,v3 02/10] dpaa_eth: add support for DPAA Ethernet Thread-Index: AQHQgoy67USkhZ9S4U2K7B2IZnjQHp2lgFmAgAAZ6PCAAHh6AIAHugHQ Date: Mon, 15 Jun 2015 12:44:14 +0000 Message-ID: References: <1430319405-31280-1-git-send-email-madalin.bucur@freescale.com> <1433947452.27504.9.camel@edumazet-glaptop2.roam.corp.google.com> In-Reply-To: <1433947452.27504.9.camel@edumazet-glaptop2.roam.corp.google.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: gmail.com; dkim=none (message not signed) header.d=none; x-originating-ip: [192.88.166.1] x-microsoft-exchange-diagnostics: 1;BY1PR0301MB0855;3:tfsTYjCIAenR+S57Qn3Mt1nU93eYp0E7S90kF6DoR2K+s3oCZhxNuYKSWXE27CniDCUC5x1oDdoyT076X/BazERX2t4H+9OBGOJiDCO18rnWZxgazf+GiR9ved8UUxT7h9X0vmrcYzpe3EkWXOpbUA==;10:HhKisby+rf9/MHk+QQCxmkpDgzCzRWIpwIy0VWOJpHm9WZjx9q5j1WRVByoGE/FL9B868WGgwdCCYb8L4XVQ7IclOzAojRe76bpwBgn0hSU=;6:Chvd9J8QkimtT/+a6NwxV5bPRdiFtpBoAdRnOoIg+51zEEmWp3lZaM5Kej3br/kh x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:BY1PR0301MB0855; x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:; x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(601004)(520003)(5005006)(3002001);SRVR:BY1PR0301MB0855;BCL:0;PCL:0;RULEID:;SRVR:BY1PR0301MB0855; x-forefront-prvs: 0608DEDB67 x-forefront-antispam-report: SFV:NSPM;SFS:(10019020)(6009001)(377424004)(24454002)(13464003)(87936001)(50986999)(54356999)(2656002)(74316001)(19580405001)(19580395003)(77156002)(62966003)(76176999)(122556002)(77096005)(15975445007)(102836002)(2950100001)(86362001)(93886004)(66066001)(46102003)(33656002)(5002640100001)(76576001)(189998001)(110136002)(106116001)(40100003)(99286002)(5001960100002)(92566002)(5003600100002)(142933001);DIR:OUT;SFP:1102;SCL:1;SRVR:BY1PR0301MB0855;H:BL2PR03MB545.namprd03.prod.outlook.com;FPR:;SPF:None;MLV:sfv;LANG:en; Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 X-OriginatorOrg: freescale.com X-MS-Exchange-CrossTenant-originalarrivaltime: 15 Jun 2015 12:44:14.4049 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 710a03f5-10f6-4d38-9ff4-a80b81da590d X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY1PR0301MB0855 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by nfs id t5FCiShr027771 Content-Length: 911 Lines: 24 > -----Original Message----- > From: Eric Dumazet [mailto:eric.dumazet@gmail.com] > > On Wed, 2015-06-10 at 07:38 +0000, Madalin-Cristian Bucur wrote: > > Hi Eric, > > > > Can you please tell us if this change would be for the better? > > > > I was about to say yes to this request but checked and no other Ethernet > driver seems to use the queue trans_start. > > I was able to find your patch "net: tx scalability works : trans_start" [ > http://patchwork.ozlabs.org/patch/27104/ ] but did not find more about this > topic. > > > > Drivers no longer have to worry about updating trans_start themselves. > Core networking stack handles this. > > Check txq_trans_update() done from netdev_start_xmit() I'll remove the updates, thank you. Madalin ????{.n?+???????+%?????ݶ??w??{.n?+????{??G?????{ay?ʇڙ?,j??f???h?????????z_??(?階?ݢj"???m??????G????????????&???~???iO???z??v?^?m???? ????????I?