Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932200AbbFOMpt (ORCPT ); Mon, 15 Jun 2015 08:45:49 -0400 Received: from mx-rz-1.rrze.uni-erlangen.de ([131.188.11.20]:34544 "EHLO mx-rz-1.rrze.uni-erlangen.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932150AbbFOMpl (ORCPT ); Mon, 15 Jun 2015 08:45:41 -0400 X-RRZE-Submit-IP: 2001:638:a000:4142::ff0f:d304 Message-ID: <557EC8F1.9010305@fau.de> Date: Mon, 15 Jun 2015 14:45:37 +0200 From: Andreas Ruprecht User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Maxime Coquelin CC: Chanwoo Choi , Peter Hurley , Vladimir Zapolskiy , Andy Shevchenko , Greg Kroah-Hartman , linux-kernel , Stefan Hengelein , Valentin Rothberg , Paul Bolle Subject: serial: stm32-usart: use of undefined SERIAL_STM32_USART_CONSOLE Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 978 Lines: 30 Hi Maxime, your commit 48a6092fb41f ("serial: stm32-usart: Add STM32 USART Driver") was merged into linux-next today (i.e., next-20150615), and contains the following piece of code: [...] #if defined(CONFIG_SERIAL_STM32_USART_CONSOLE) && defined(CONFIG_MAGIC_SYSRQ) #define SUPPORT_SYSRQ #endif [...] The #if block can never be enabled as no symbol named SERIAL_STM32_USART_CONSOLE is defined in Kconfig. Did you maybe mean SERIAL_STM32_CONSOLE which you introduce in the same commit? I detected the issue by running undertaker-checkpatch from the Undertaker tool suite (https://undertaker.cs.fau.de). There is also a tool in the Linux tree itself that can detect such issues (scripts/checkkconfigsymbols.py). Regards, Andreas -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/