Date: Mon, 15 Jun 2015 14:48:52 +0200
From: Peter Zijlstra <peterz@infradead.org>
To: Vikas Shivappa <vikas.shivappa@linux.intel.com>
Cc: linux-kernel@vger.kernel.org, vikas.shivappa@intel.com, x86@kernel.org,
        hpa@zytor.com, tglx@linutronix.de, mingo@kernel.org,
        matt.fleming@intel.com, will.auld@intel.com,
        linux-rdt@eclists.intel.com
Subject: Re: [PATCH 05/10] x86/intel_rdt: Add support for Cache Allocation
 detection
Message-ID: <20150615124852.GC3644@twins.programming.kicks-ass.net>
References: <1434133037-25189-1-git-send-email-vikas.shivappa@linux.intel.com>
 <1434133037-25189-6-git-send-email-vikas.shivappa@linux.intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1434133037-25189-6-git-send-email-vikas.shivappa@linux.intel.com>
User-Agent: Mutt/1.5.21 (2012-12-30)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 872
Lines: 25

On Fri, Jun 12, 2015 at 11:17:12AM -0700, Vikas Shivappa wrote:
> +	/* Additional Intel-defined flags: level 0x00000010 */
> +	if (c->cpuid_level >= 0x00000010) {
> +		u32 eax, ebx, ecx, edx;
> +
> +		cpuid_count(0x00000010, 0, &eax, &ebx, &ecx, &edx);
> +		c->x86_capability[13] = ebx;
> +
> +		if (cpu_has(c, X86_FEATURE_CAT_L3)) {
> +
> +			cpuid_count(0x00000010, 1, &eax, &ebx, &ecx, &edx);
> +			c->x86_rdt_max_closid = edx + 1;
> +			c->x86_rdt_max_cbm_len = eax + 1;
> +		}
> +	}

I'm still annoyed by the whole RDT/CAT thing, so the above reads a CAT
leaf and puts the values in an RDT variable.

That's inconsistent.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/