Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755504AbbFOOFR (ORCPT ); Mon, 15 Jun 2015 10:05:17 -0400 Received: from casper.infradead.org ([85.118.1.10]:40571 "EHLO casper.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753810AbbFOOFL (ORCPT ); Mon, 15 Jun 2015 10:05:11 -0400 Date: Mon, 15 Jun 2015 16:05:03 +0200 From: Peter Zijlstra To: Vikas Shivappa Cc: linux-kernel@vger.kernel.org, vikas.shivappa@intel.com, x86@kernel.org, hpa@zytor.com, tglx@linutronix.de, mingo@kernel.org, matt.fleming@intel.com, will.auld@intel.com, linux-rdt@eclists.intel.com Subject: Re: [PATCH 10/10] x86/intel_rdt: Intel haswell Cache Allocation enumeration Message-ID: <20150615140503.GD3644@twins.programming.kicks-ass.net> References: <1434133037-25189-1-git-send-email-vikas.shivappa@linux.intel.com> <1434133037-25189-11-git-send-email-vikas.shivappa@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1434133037-25189-11-git-send-email-vikas.shivappa@linux.intel.com> User-Agent: Mutt/1.5.21 (2012-12-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 769 Lines: 22 On Fri, Jun 12, 2015 at 11:17:17AM -0700, Vikas Shivappa wrote: > + /* > + * Probe test for Haswell CPUs. > + */ > + if (c->x86 == 0x6 && c->x86_model == 0x3f) > + return hsw_probetest(); Firstly, isn't a probe already a test? Secondly, there's more HSW models: case 60: /* 22nm Haswell Core */ case 63: /* 22nm Haswell Server */ case 69: /* 22nm Haswell ULT */ case 70: /* 22nm Haswell + GT3e (Intel Iris Pro graphics) */ Is this really only HSW server, or should they all be listed? -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/