Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754566AbbFOOZR (ORCPT ); Mon, 15 Jun 2015 10:25:17 -0400 Received: from bh-25.webhostbox.net ([208.91.199.152]:44162 "EHLO bh-25.webhostbox.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752083AbbFOOZL (ORCPT ); Mon, 15 Jun 2015 10:25:11 -0400 Message-ID: <557EE045.2090503@roeck-us.net> Date: Mon, 15 Jun 2015 07:25:09 -0700 From: Guenter Roeck User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 MIME-Version: 1.0 To: Marcel Holtmann CC: "linux-kernel@vger.kernel.org" , Frederic Danis , BlueZ development , linux-serial@vger.kernel.org Subject: Re: Build error -in -next due to 'Bluetooth: hci_uart: Support operational speed during setup' References: <557ED81D.7090908@roeck-us.net> <7CF3D545-DAE4-4510-9726-5D40740DDC5D@holtmann.org> In-Reply-To: <7CF3D545-DAE4-4510-9726-5D40740DDC5D@holtmann.org> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-Authenticated_sender: linux@roeck-us.net X-OutGoing-Spam-Status: No, score=-1.0 X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - bh-25.webhostbox.net X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - roeck-us.net X-Get-Message-Sender-Via: bh-25.webhostbox.net: authenticated_id: linux@roeck-us.net X-Source: X-Source-Args: X-Source-Dir: Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1034 Lines: 28 On 06/15/2015 06:58 AM, Marcel Holtmann wrote: > Hi Guenter, > >> alpha:allmodconfig fails to build in -next with >> >> drivers/bluetooth/hci_ldisc.c: In function 'hci_uart_set_baudrate': >> drivers/bluetooth/hci_ldisc.c:276:22: error: 'BOTHER' undeclared >> >> BOTHER is not defined for all architectures and otherwise only >> used with '#ifdef BOTHER'. > > thanks for the report. Is this something that should be #ifdef at the using side or maybe just fixed for the other architectures. > So far it has been fixed with #ifdef, and this is the first code which uses it outside drivers/tty. So my first tendency would be to fix it on the user side. However, looking into it, I think only alpha and avr32 are affected. Let me submit patches against those and see where it goes. Guenter -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/