Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756038AbbFOOiz (ORCPT ); Mon, 15 Jun 2015 10:38:55 -0400 Received: from mail-gw1-out.broadcom.com ([216.31.210.62]:40917 "EHLO mail-gw1-out.broadcom.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754460AbbFOOir convert rfc822-to-8bit (ORCPT ); Mon, 15 Jun 2015 10:38:47 -0400 X-IronPort-AV: E=Sophos;i="5.13,618,1427785200"; d="scan'208";a="67577022" From: Ilya Faenson To: Guenter Roeck , Marcel Holtmann CC: "linux-kernel@vger.kernel.org" , "Frederic Danis" , BlueZ development , "linux-serial@vger.kernel.org" Subject: RE: Build error -in -next due to 'Bluetooth: hci_uart: Support operational speed during setup' Thread-Topic: Build error -in -next due to 'Bluetooth: hci_uart: Support operational speed during setup' Thread-Index: AQHQp3OFkdaSHNOafEyMmQlx2WAaBJ2uFJuA//+NLxA= Date: Mon, 15 Jun 2015 14:38:45 +0000 Message-ID: References: <557ED81D.7090908@roeck-us.net> <7CF3D545-DAE4-4510-9726-5D40740DDC5D@holtmann.org> <557EE045.2090503@roeck-us.net> In-Reply-To: <557EE045.2090503@roeck-us.net> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.9.208.64] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1829 Lines: 43 Hi Guenter, -----Original Message----- From: linux-bluetooth-owner@vger.kernel.org [mailto:linux-bluetooth-owner@vger.kernel.org] On Behalf Of Guenter Roeck Sent: Monday, June 15, 2015 10:25 AM To: Marcel Holtmann Cc: linux-kernel@vger.kernel.org; Frederic Danis; BlueZ development; linux-serial@vger.kernel.org Subject: Re: Build error -in -next due to 'Bluetooth: hci_uart: Support operational speed during setup' On 06/15/2015 06:58 AM, Marcel Holtmann wrote: > Hi Guenter, > >> alpha:allmodconfig fails to build in -next with >> >> drivers/bluetooth/hci_ldisc.c: In function 'hci_uart_set_baudrate': >> drivers/bluetooth/hci_ldisc.c:276:22: error: 'BOTHER' undeclared >> >> BOTHER is not defined for all architectures and otherwise only >> used with '#ifdef BOTHER'. > > thanks for the report. Is this something that should be #ifdef at the using side or maybe just fixed for the other architectures. > So far it has been fixed with #ifdef, and this is the first code which uses it outside drivers/tty. So my first tendency would be to fix it on the user side. However, looking into it, I think only alpha and avr32 are affected. Let me submit patches against those and see where it goes. IF: The BOTHER flag should not be involved in setting the baud rate at all. I've published a patch last week that implements the hci_uart_set_baudrate properly (in my opinion). Guenter -- To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/