Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755884AbbFOOt4 (ORCPT ); Mon, 15 Jun 2015 10:49:56 -0400 Received: from mezzanine.sirena.org.uk ([106.187.55.193]:58730 "EHLO mezzanine.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753288AbbFOOtu (ORCPT ); Mon, 15 Jun 2015 10:49:50 -0400 Date: Mon, 15 Jun 2015 15:49:33 +0100 From: Mark Brown To: Sergej Sawazki Cc: gregkh@linuxfoundation.org, wsa@the-dreams.de, linux-kernel@vger.kernel.org Message-ID: <20150615144933.GO18309@sirena.org.uk> References: <557C2E3E.80000@gmx.de> <20150615094922.GB18309@sirena.org.uk> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="iEWWOZ/QYGWEaBRW" Content-Disposition: inline In-Reply-To: X-Cookie: do { User-Agent: Mutt/1.5.23 (2014-03-12) X-SA-Exim-Connect-IP: 81.129.82.198 X-SA-Exim-Mail-From: broonie@sirena.org.uk Subject: Re: [BUG ?] regmap: debugfs: WARN_ON at regmap-debugfs.c:151 X-SA-Exim-Version: 4.2.1 (built Mon, 26 Dec 2011 16:24:06 +0000) X-SA-Exim-Scanned: Yes (on mezzanine.sirena.org.uk) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1766 Lines: 45 --iEWWOZ/QYGWEaBRW Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Mon, Jun 15, 2015 at 02:42:30PM +0200, Sergej Sawazki wrote: > Am 15. Juni 2015 11:49:22 MESZ, schrieb Mark Brown : > >We need to change that code to special case write only register maps > >like this and just skip having a cache for those devices. They > >normally > >have very small register maps anyway so it shouldn't have too big an > >impact on performance. > I'm having this issue with a wm8741 DAC, its register map is not > "write only", it has readable and writeable registers. Are you *sure* there are physically readable registers on the device? It's difficult to implement for 7x9 devices given that the top register bit is in the byte used to send the register address, I expect you'll find that the registers marked as readable are actually those that should be cached. --iEWWOZ/QYGWEaBRW Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJVfuX8AAoJECTWi3JdVIfQyTwH/jgRBfaD0oDonW3U0Eo42VcC WiWM3p/7JdYXGY+fZJg4R3ozMI6xyKd2lyJNMOqc+x5wY1iPF9tjNmRNBYl9o2XW RHH5wKQlaPsLOZDfhBq4eGbGsHtev2hjXmUaHfSnzrog4gdmteXNbMqUCTRWPWCB ECK7AsuNyRVdJtQ5kXBesEqOEhB8lDwANiiuNOLMRZ7acyX1XynMqToSIvnSXFZU v28Is9Q2PU4hWZzyKUZAlKbgY9n512Jm/WAqL8w8m0w6GileVDv+hs2ewWwuUabT IZM/QhOI4GeZg/dMoGU7xHRhLPQT4lAiPiT4Iv3EPxNkLnacCuXJO4YGY+GfWfE= =szAx -----END PGP SIGNATURE----- --iEWWOZ/QYGWEaBRW-- -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/