Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755663AbbFORHa (ORCPT ); Mon, 15 Jun 2015 13:07:30 -0400 Received: from mga02.intel.com ([134.134.136.20]:3074 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754404AbbFORHW (ORCPT ); Mon, 15 Jun 2015 13:07:22 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.13,620,1427785200"; d="scan'208";a="747070936" Date: Mon, 15 Jun 2015 10:04:31 -0700 (PDT) From: Vikas Shivappa X-X-Sender: vikas@vshiva-Udesk To: Peter Zijlstra cc: Vikas Shivappa , linux-kernel@vger.kernel.org, vikas.shivappa@intel.com, x86@kernel.org, hpa@zytor.com, tglx@linutronix.de, mingo@kernel.org, matt.fleming@intel.com, will.auld@intel.com, linux-rdt@eclists.intel.com Subject: Re: [PATCH 05/10] x86/intel_rdt: Add support for Cache Allocation detection In-Reply-To: <20150615124852.GC3644@twins.programming.kicks-ass.net> Message-ID: References: <1434133037-25189-1-git-send-email-vikas.shivappa@linux.intel.com> <1434133037-25189-6-git-send-email-vikas.shivappa@linux.intel.com> <20150615124852.GC3644@twins.programming.kicks-ass.net> User-Agent: Alpine 2.10 (DEB 1266 2009-07-14) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1050 Lines: 34 On Mon, 15 Jun 2015, Peter Zijlstra wrote: > On Fri, Jun 12, 2015 at 11:17:12AM -0700, Vikas Shivappa wrote: >> + /* Additional Intel-defined flags: level 0x00000010 */ >> + if (c->cpuid_level >= 0x00000010) { >> + u32 eax, ebx, ecx, edx; >> + >> + cpuid_count(0x00000010, 0, &eax, &ebx, &ecx, &edx); >> + c->x86_capability[13] = ebx; >> + >> + if (cpu_has(c, X86_FEATURE_CAT_L3)) { >> + >> + cpuid_count(0x00000010, 1, &eax, &ebx, &ecx, &edx); >> + c->x86_rdt_max_closid = edx + 1; >> + c->x86_rdt_max_cbm_len = eax + 1; >> + } >> + } > > I'm still annoyed by the whole RDT/CAT thing, so the above reads a CAT > leaf and puts the values in an RDT variable. Will fix. Was confusing as the closid is generic for rdt but just that its enumerated for each leaf .. > > That's inconsistent. > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/