Date: Mon, 15 Jun 2015 22:25:14 +0200
From: Ingo Molnar <mingo@kernel.org>
To: Denys Vlasenko <dvlasenk@redhat.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
        Steven Rostedt <rostedt@goodmis.org>, Borislav Petkov <bp@alien8.de>,
        "H. Peter Anvin" <hpa@zytor.com>,
        Andy Lutomirski <luto@amacapital.net>, Oleg Nesterov <oleg@redhat.com>,
        Frederic Weisbecker <fweisbec@gmail.com>,
        Alexei Starovoitov <ast@plumgrid.com>, Will Drewry <wad@chromium.org>,
        Kees Cook <keescook@chromium.org>, x86@kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] x86/asm/entry/32, selftests: Add test_syscall_vdso
 test
Message-ID: <20150615202514.GC12450@gmail.com>
References: <1434122983-12337-1-git-send-email-dvlasenk@redhat.com>
 <20150613063941.GA13398@gmail.com>
 <557D7878.5000105@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <557D7878.5000105@redhat.com>
User-Agent: Mutt/1.5.23 (2014-03-12)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1338
Lines: 42


* Denys Vlasenko <dvlasenk@redhat.com> wrote:

> On 06/13/2015 08:39 AM, Ingo Molnar wrote:
> > 
> > * Denys Vlasenko <dvlasenk@redhat.com> wrote:
> > 
> >> The test is fairly simplistic: it checks that all registers
> >> are preserved across 32-bit syscall via VDSO.
> >>
> >> Run-tested:
> >>
> >> $ ./test_syscall_vdso_32
> >> [RUN]	Executing 6-argument 32-bit syscall via VDSO
> >> [Ok]	Arguments are preserved across syscall
> >> [RUN]	Executing 6-argument 32-bit syscall via INT 80
> >> [Ok]	Arguments are preserved across syscall
> >> [RUN]	Running tests under ptrace
> >> [RUN]	Executing 6-argument 32-bit syscall via VDSO
> >> [Ok]	Arguments are preserved across syscall
> >> [RUN]	Executing 6-argument 32-bit syscall via INT 80
> >> [Ok]	Arguments are preserved across syscall
> > 
> > Just curious: is there a kernel sha1 where this test would fail? Or did you try to 
> > provoke an information leak perhaps?
> 
> I did see failures, more than once, when testing my own patches.

Ok!

> I'm not aware of released kernels which are buggy wrt this test.

Great! :-)

Thanks,

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/