Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756028AbbFOUow (ORCPT ); Mon, 15 Jun 2015 16:44:52 -0400 Received: from mail-yh0-f44.google.com ([209.85.213.44]:33771 "EHLO mail-yh0-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754277AbbFOUon (ORCPT ); Mon, 15 Jun 2015 16:44:43 -0400 MIME-Version: 1.0 In-Reply-To: <1434386579-6045-1-git-send-email-dave.long@linaro.org> References: <1434386579-6045-1-git-send-email-dave.long@linaro.org> Date: Mon, 15 Jun 2015 13:44:42 -0700 X-Google-Sender-Auth: fjEBHau2agDX6BVc9QqcG4dBWPM Message-ID: Subject: Re: [PATCH 0/2] Consolidate redundant register/stack access code From: Kees Cook To: David Long Cc: "H. Peter Anvin" , Andy Lutomirski , Anton Blanchard , Behan Webster , Benjamin Herrenschmidt , Eric Paris , Heiko Carstens , Ingo Molnar , Jan Willeke , Martin Schwidefsky , Michael Ellerman , Nikolay Borisov , Oleg Nesterov , Paul Mackerras , Richard Kuo , Robert Richter , Roland McGrath , Russell King , Tejun Heo , Thomas Gleixner , Will Deacon , "linux-arm-kernel@lists.infradead.org" , linux-hexagon@vger.kernel.org, LKML , "linux-s390@vger.kernel.org" , linux-sh , "linux390@de.ibm.com" , "linuxppc-dev@lists.ozlabs.org" , "x86@kernel.org" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2163 Lines: 52 On Mon, Jun 15, 2015 at 9:42 AM, David Long wrote: > From: "David A. Long" > > Move duplicate and functionally equivalent code for accessing registers > and stack (CONFIG_HAVE_REGS_AND_STACK_ACCESS_API) from arch subdirs into > common kernel files. > > Note: Help regression testing s390, hexagon, and sh would be appreciated. > Powerpc builds but I have not verified the functionality. > > David A. Long (2): > Move the pt_regs_offset struct definition from arch to common include > file > Consolidate redundant register/stack access code > > arch/arm/include/asm/ptrace.h | 6 --- > arch/arm/kernel/ptrace.c | 72 +--------------------------------- > arch/hexagon/include/uapi/asm/ptrace.h | 3 -- > arch/powerpc/include/asm/ptrace.h | 38 ------------------ > arch/powerpc/kernel/ptrace.c | 39 +----------------- > arch/s390/include/asm/ptrace.h | 3 -- > arch/s390/kernel/ptrace.c | 70 ++++++++++----------------------- > arch/sh/include/asm/ptrace.h | 44 --------------------- > arch/sh/kernel/Makefile | 2 +- > arch/sh/kernel/ptrace.c | 33 ---------------- > arch/sh/kernel/ptrace_32.c | 2 +- > arch/sh/kernel/ptrace_64.c | 2 +- > arch/x86/include/asm/ptrace.h | 37 ----------------- > arch/x86/kernel/ptrace.c | 39 +----------------- > include/linux/ptrace.h | 51 ++++++++++++++++++++++++ > kernel/ptrace.c | 38 ++++++++++++++++++ > 16 files changed, 116 insertions(+), 363 deletions(-) > delete mode 100644 arch/sh/kernel/ptrace.c I love the deletions:insertions ratio! :) Reviewed-by: Kees Cook I wonder why arm64 doesn't define CONFIG_HAVE_REGS_AND_STACK_ACCESS_API? Thanks! -Kees -- Kees Cook Chrome OS Security -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/