Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755969AbbFOVln (ORCPT ); Mon, 15 Jun 2015 17:41:43 -0400 Received: from bh-25.webhostbox.net ([208.91.199.152]:46212 "EHLO bh-25.webhostbox.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750976AbbFOVle (ORCPT ); Mon, 15 Jun 2015 17:41:34 -0400 Message-ID: <557F4689.1050907@roeck-us.net> Date: Mon, 15 Jun 2015 14:41:29 -0700 From: Guenter Roeck User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 MIME-Version: 1.0 To: Vivien Didelot , linux-watchdog@vger.kernel.org CC: Wim Van Sebroeck , linux-kernel@vger.kernel.org, kernel@savoirfairelinux.com Subject: Re: [RESEND PATCH 0/3] watchdog: MAX63xx cleanup and platform settings References: <1434398321-16035-1-git-send-email-vivien.didelot@savoirfairelinux.com> In-Reply-To: <1434398321-16035-1-git-send-email-vivien.didelot@savoirfairelinux.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-Authenticated_sender: linux@roeck-us.net X-OutGoing-Spam-Status: No, score=-1.0 X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - bh-25.webhostbox.net X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - roeck-us.net X-Get-Message-Sender-Via: bh-25.webhostbox.net: authenticated_id: linux@roeck-us.net X-Source: X-Source-Args: X-Source-Dir: Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 860 Lines: 22 On 06/15/2015 12:58 PM, Vivien Didelot wrote: > The first version of this patchset from January, 29 [1] got no feedback > from the maintainer. 1/4 [2] was applied to watchdog-next on May, 30 > though. A concern about constants removal was raised in the preliminary > 2/4 cleanup patch, the explanation has been added to the related commit > message. > Hi Vivien, For my part, adding a comment about removal of constants does not alleviate my concern about removing those constants. I just don't believe that removing constants is a good idea, no matter what the arguments for doing so might be. Thanks, Guenter -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/