Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756123AbbFOVr0 (ORCPT ); Mon, 15 Jun 2015 17:47:26 -0400 Received: from mga14.intel.com ([192.55.52.115]:5987 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750960AbbFOVrS (ORCPT ); Mon, 15 Jun 2015 17:47:18 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.13,621,1427785200"; d="scan'208";a="727934759" Date: Mon, 15 Jun 2015 14:44:32 -0700 (PDT) From: Vikas Shivappa X-X-Sender: vikas@vshiva-Udesk To: Peter Zijlstra cc: Vikas Shivappa , linux-kernel@vger.kernel.org, vikas.shivappa@intel.com, x86@kernel.org, hpa@zytor.com, tglx@linutronix.de, mingo@kernel.org, Matt Fleming , "Juvva, Kanaka D" , "Williamson, Glenn P" , "Auld, Will" Subject: Re: [PATCH 10/10] x86/intel_rdt: Intel haswell Cache Allocation enumeration In-Reply-To: <20150615140503.GD3644@twins.programming.kicks-ass.net> Message-ID: References: <1434133037-25189-1-git-send-email-vikas.shivappa@linux.intel.com> <1434133037-25189-11-git-send-email-vikas.shivappa@linux.intel.com> <20150615140503.GD3644@twins.programming.kicks-ass.net> User-Agent: Alpine 2.10 (DEB 1266 2009-07-14) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; format=flowed; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 933 Lines: 34 On Mon, 15 Jun 2015, Peter Zijlstra wrote: > On Fri, Jun 12, 2015 at 11:17:17AM -0700, Vikas Shivappa wrote: >> + /* >> + * Probe test for Haswell CPUs. >> + */ >> + if (c->x86 == 0x6 && c->x86_model == 0x3f) >> + return hsw_probetest(); > > Firstly, isn't a probe already a test? Will fix the name to hsw_probe > > Secondly, there's more HSW models: > > case 60: /* 22nm Haswell Core */ > case 63: /* 22nm Haswell Server */ > case 69: /* 22nm Haswell ULT */ > case 70: /* 22nm Haswell + GT3e (Intel Iris Pro graphics) */ > > Is this really only HSW server, Yes , this probe is only targeted at HSW servers as of now. or should they all be listed? > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/