Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752119AbbFOX3m (ORCPT ); Mon, 15 Jun 2015 19:29:42 -0400 Received: from mail.savoirfairelinux.com ([209.172.62.77]:55052 "EHLO mail.savoirfairelinux.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751353AbbFOX3e (ORCPT ); Mon, 15 Jun 2015 19:29:34 -0400 Date: Mon, 15 Jun 2015 19:29:30 -0400 (EDT) From: Vivien Didelot To: Guenter Roeck Cc: linux-watchdog , Wim Van Sebroeck , linux-kernel , kernel Message-ID: <452754143.100967.1434410970055.JavaMail.zimbra@savoirfairelinux.com> In-Reply-To: <557F4689.1050907@roeck-us.net> References: <1434398321-16035-1-git-send-email-vivien.didelot@savoirfairelinux.com> <557F4689.1050907@roeck-us.net> Subject: Re: [RESEND PATCH 0/3] watchdog: MAX63xx cleanup and platform settings MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Mailer: Zimbra 8.6.0_GA_1153 (ZimbraWebClient - FF38 (Linux)/8.6.0_GA_1153) Thread-Topic: watchdog: MAX63xx cleanup and platform settings Thread-Index: XUuwcWU43/1r3xrZ/mF3sxxJ9y1OSw== Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1046 Lines: 28 Hi Guenter, On Jun 15, 2015, at 5:41 PM, Guenter Roeck linux@roeck-us.net wrote: > On 06/15/2015 12:58 PM, Vivien Didelot wrote: >> The first version of this patchset from January, 29 [1] got no feedback >> from the maintainer. 1/4 [2] was applied to watchdog-next on May, 30 >> though. A concern about constants removal was raised in the preliminary >> 2/4 cleanup patch, the explanation has been added to the related commit >> message. >> > > Hi Vivien, > > For my part, adding a comment about removal of constants does not alleviate > my concern about removing those constants. I just don't believe that removing > constants is a good idea, no matter what the arguments for doing so might be. Ok then, I'll minimize this cleanup patch and keep MAX6369_WDSET and MAX6369_WDI as is. Thanks, -v -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/