Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752750AbbFPDSK (ORCPT ); Mon, 15 Jun 2015 23:18:10 -0400 Received: from mail-pa0-f41.google.com ([209.85.220.41]:34630 "EHLO mail-pa0-f41.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751251AbbFPDSC (ORCPT ); Mon, 15 Jun 2015 23:18:02 -0400 Date: Tue, 16 Jun 2015 08:47:57 +0530 From: Viresh Kumar To: Stephen Warren Cc: Thomas Gleixner , Daniel Lezcano , linaro-kernel@lists.linaro.org, linux-kernel@vger.kernel.org, Lee Jones Subject: Re: [PATCH V2 4/7] clocksource: bcm2835: Migrate to new 'set-state' interface Message-ID: <20150616031757.GC26592@linux> References: <557F908C.3010600@wwwdotorg.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <557F908C.3010600@wwwdotorg.org> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1850 Lines: 42 On 15-06-15, 20:57, Stephen Warren wrote: > On 06/12/2015 02:00 AM, Viresh Kumar wrote: > > Migrate bcm2835 driver to the new 'set-state' interface provided by > > the clockevents core, the earlier 'set-mode' interface is marked > > obsolete now. > > > > This also enables us to implement callbacks for new states of clockevent > > devices, for example: ONESHOT_STOPPED. > > > > We weren't doing anything in the ->set_mode() callback. So, this patch > > doesn't provide any set-state callbacks. > > This generates a panic at boot (on top of 4.1.0-rc8+, which certainly at > least booted fine): > > > [ 0.008586] clocksource timer: mask: 0xffffffff max_cycles: 0xffffffff, max_idle_ns: 1911260446275 ns > > [ 0.018080] ------------[ cut here ]------------ > > [ 0.022843] kernel BUG at kernel/time/clockevents.c:480! > > [ 0.028299] Internal error: Oops - BUG: 0 [#1] ARM > > [ 0.033237] CPU: 0 PID: 0 Comm: swapper Not tainted 4.1.0-rc8+ #46 > > [ 0.039567] Hardware name: BCM2835 > > [ 0.043092] task: c06fb648 ti: c06f6000 task.ti: c06f6000 > > [ 0.048668] PC is at clockevents_register_device+0x15c/0x174 This failed the sanity checks of clockevents core. Did you apply the first patch as well? Yes, its very much required. Also, there were dependencies on the latest tip, prepared for 4.2 merge window and would have been better if you tested on top of that. But those dependencies are for some helpers which aren't used in this patch. So, it might work over rc8 + the first patch from this series.. In case it doesn't, please test it over tip/master once. -- viresh -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/